Skip to content

Fix session timeout when using multiple windows or tabs#7459

Merged
mrcasals merged 13 commits intodecidim:developfrom
mainio:fix/multiple_tabs_session_timeout
Feb 25, 2021
Merged

Fix session timeout when using multiple windows or tabs#7459
mrcasals merged 13 commits intodecidim:developfrom
mainio:fix/multiple_tabs_session_timeout

Conversation

@lahdeero
Copy link
Copy Markdown
Contributor

🎩 What? Why?

There is problem after #7282 that if user is using Decidim with multiple tabs or windows and some tab or window is idle, user gets signed out. This can be frustrating for admins when they fill out a long form and submit fails because other window has signed them out. In this pull request we check when is the last request made to a server before automatically signing user out.

📌 Related Issues

#7282

Testing

  1. Sign in
  2. Open link (processes for example) to new window
  3. Use one window and idle in other

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@lahdeero lahdeero changed the title Fix multiple windows session timeout Fix session timeout when using multiple windows or tabs Feb 24, 2021
@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Feb 25, 2021
@mrcasals mrcasals merged commit 5d4b403 into decidim:develop Feb 25, 2021
@ahukkanen ahukkanen deleted the fix/multiple_tabs_session_timeout branch February 25, 2021 10:20
entantoencuanto added a commit that referenced this pull request Feb 25, 2021
* develop: (232 commits)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  Resort Menus (#7460)
  Polling Officer Zone (#7439)
  Fix session timeout when using multiple windows or tabs (#7459)
  Fix display of debates with multiple dates (#7393)
  chore: split election tests (#7451)
  style: make selected values primary labels with delete button (#7448)
  Fix and tests to avoid registered users being invited again (#7392)
  Migrate Admin menus to Menu Registry (#7368)
  New Crowdin updates (#7338)
  Bump to carrierwave 2.2.0 (#7441)
  Voting: show callout when Polling Stations miss Polling Officers (#7417)
  Further default orders for the API (#7436)
  Fix random order inconsistencies (#7437)
  Ensure Rails is locked to 5.2.4.x series (#7430)
  Add default order by ID to API list queries (#7424)
  Update dependencies (#7422)
  Ignore warning on CI when no artifacts to upload (#7420)
  Filter and search polling officers (#7411)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants