Skip to content

Add Polling Officer Zone#7439

Merged
mrcasals merged 8 commits intodevelopfrom
feat/polling-officer-zone
Feb 25, 2021
Merged

Add Polling Officer Zone#7439
mrcasals merged 8 commits intodevelopfrom
feat/polling-officer-zone

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Feb 23, 2021

🎩 What? Why?

This PR introduces 2 features:

  1. Allows a user acting as a Polling Officer to access the Polling Officer Zone from their account page;
  2. Notifies a user when they are assigned as president/manager of a Polling Station with the instructions on how to access the Polling Officer Zone.
1. Polling Officer Zone

The Polling Officer Zone is based on the Trustee Zone implemented here: #6615

Notice that, for the moment, a Polling Officer can only see the Polling Stations they are assigned to, while the actions they con perform on the PS are not yet implemented (blank page).
The UI is rough and will be improved in upcoming tasks (and well the design will be available).

2. Polling Officer Notification

In order to only send notifications to Officers when they are assigned to a Polling Station, and not when other Polling Officers are added/removed, we now assign/unassign only those officers that need it (instead of unassign all old + assign all new as done before)

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
POLLING OFFICER ZONE
Screenshot 2021-02-23 at 13 05 34

NOTIFICATION
Screenshot 2021-02-23 at 13 04 53

EMAIL
Screenshot 2021-02-23 at 13 16 34

♥️ Thank you!

@orlera orlera force-pushed the feat/polling-officer-zone branch from db22eb6 to a131b20 Compare February 23, 2021 07:12
@orlera orlera changed the title Feat/polling officer zone Polling Officer Zone Feb 23, 2021
@orlera orlera self-assigned this Feb 23, 2021
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Feb 25, 2021

@decidim/mantainers this has been approved by product and it's ready for review 🔎

Notice that it is falling short on coverage due to lack of testing of PollingOfficerZone::PollingStationsController which is not doing anything at the moment and will be implemented (and tested) in follow-up PRs.

@mrcasals mrcasals marked this pull request as ready for review February 25, 2021 10:24
@mrcasals mrcasals merged commit 6a6e821 into develop Feb 25, 2021
@mrcasals mrcasals deleted the feat/polling-officer-zone branch February 25, 2021 10:27
@mrcasals mrcasals changed the title Polling Officer Zone Add Polling Officer Zone Feb 25, 2021
entantoencuanto added a commit that referenced this pull request Feb 25, 2021
* develop: (232 commits)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  Resort Menus (#7460)
  Polling Officer Zone (#7439)
  Fix session timeout when using multiple windows or tabs (#7459)
  Fix display of debates with multiple dates (#7393)
  chore: split election tests (#7451)
  style: make selected values primary labels with delete button (#7448)
  Fix and tests to avoid registered users being invited again (#7392)
  Migrate Admin menus to Menu Registry (#7368)
  New Crowdin updates (#7338)
  Bump to carrierwave 2.2.0 (#7441)
  Voting: show callout when Polling Stations miss Polling Officers (#7417)
  Further default orders for the API (#7436)
  Fix random order inconsistencies (#7437)
  Ensure Rails is locked to 5.2.4.x series (#7430)
  Add default order by ID to API list queries (#7424)
  Update dependencies (#7422)
  Ignore warning on CI when no artifacts to upload (#7420)
  Filter and search polling officers (#7411)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Access to the Polling Officer Zone

2 participants