Conversation
db22eb6 to
a131b20
Compare
added 7 commits
February 23, 2021 12:00
66eed09 to
dd8d92b
Compare
Contributor
Author
|
@decidim/mantainers this has been approved by product and it's ready for review 🔎 Notice that it is falling short on coverage due to lack of testing of |
mrcasals
approved these changes
Feb 25, 2021
entantoencuanto
added a commit
that referenced
this pull request
Feb 25, 2021
* develop: (232 commits) Add Votings to Open Data export (#7388) Add order in not highlighted assemblies by weight (#7444) Resort Menus (#7460) Polling Officer Zone (#7439) Fix session timeout when using multiple windows or tabs (#7459) Fix display of debates with multiple dates (#7393) chore: split election tests (#7451) style: make selected values primary labels with delete button (#7448) Fix and tests to avoid registered users being invited again (#7392) Migrate Admin menus to Menu Registry (#7368) New Crowdin updates (#7338) Bump to carrierwave 2.2.0 (#7441) Voting: show callout when Polling Stations miss Polling Officers (#7417) Further default orders for the API (#7436) Fix random order inconsistencies (#7437) Ensure Rails is locked to 5.2.4.x series (#7430) Add default order by ID to API list queries (#7424) Update dependencies (#7422) Ignore warning on CI when no artifacts to upload (#7420) Filter and search polling officers (#7411) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR introduces 2 features:
1. Polling Officer Zone
The Polling Officer Zone is based on the Trustee Zone implemented here: #6615
Notice that, for the moment, a Polling Officer can only see the Polling Stations they are assigned to, while the actions they con perform on the PS are not yet implemented (blank page).
The UI is rough and will be improved in upcoming tasks (and well the design will be available).
2. Polling Officer Notification
In order to only send notifications to Officers when they are assigned to a Polling Station, and not when other Polling Officers are added/removed, we now assign/unassign only those officers that need it (instead of unassign all old + assign all new as done before)
📌 Related Issues
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing

POLLING OFFICER ZONE
NOTIFICATION

EMAIL
