Voting: show callout when Polling Stations miss Polling Officers#7417
Merged
Voting: show callout when Polling Stations miss Polling Officers#7417
Conversation
cb4016c to
4e97c08
Compare
12 tasks
4e97c08 to
2488355
Compare
agustibr
previously approved these changes
Feb 18, 2021
Contributor
agustibr
left a comment
There was a problem hiding this comment.
Good work! 😃
Just left a comment about using a cell for the callout.
decidim-elections/app/views/layouts/decidim/admin/voting.html.erb
Outdated
Show resolved
Hide resolved
a4fb266 to
4a07372
Compare
Contributor
Author
|
@decidim/mantainers this is the final PR of that will close #7105 and #7106 and has been approved by product. |
mrcasals
approved these changes
Feb 23, 2021
Contributor
|
Yay! Congratulations, @orlera!! |
entantoencuanto
added a commit
that referenced
this pull request
Feb 25, 2021
* develop: (232 commits) Add Votings to Open Data export (#7388) Add order in not highlighted assemblies by weight (#7444) Resort Menus (#7460) Polling Officer Zone (#7439) Fix session timeout when using multiple windows or tabs (#7459) Fix display of debates with multiple dates (#7393) chore: split election tests (#7451) style: make selected values primary labels with delete button (#7448) Fix and tests to avoid registered users being invited again (#7392) Migrate Admin menus to Menu Registry (#7368) New Crowdin updates (#7338) Bump to carrierwave 2.2.0 (#7441) Voting: show callout when Polling Stations miss Polling Officers (#7417) Further default orders for the API (#7436) Fix random order inconsistencies (#7437) Ensure Rails is locked to 5.2.4.x series (#7430) Add default order by ID to API list queries (#7424) Update dependencies (#7422) Ignore warning on CI when no artifacts to upload (#7420) Filter and search polling officers (#7411) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This is the final PR for #7105 and #7106 🎉
To prevent the user from misconfiguring an in person/hybrid Voting, we show a callout whenever there are Polling Stations with no President or Manager(s) assigned.
This is similar to what happens when a Voting is online/hybrid and there is no Election component in the space (#7217)
📌 Related Issues
Link your PR to an issue
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots