Fix display of debates with multiple dates#7393
Merged
mrcasals merged 3 commits intodecidim:developfrom Feb 24, 2021
Merged
Conversation
2fdae03 to
bd9d16a
Compare
This was referenced Feb 18, 2021
Contributor
Author
|
@decidim/mantainers could you review this when you have a moment? :) Thanks! ❤️ |
mrcasals
approved these changes
Feb 24, 2021
Contributor
mrcasals
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
| # end: model.end_time | ||
| # } | ||
| # | ||
| class DateCell < Decidim::ViewModel |
entantoencuanto
added a commit
that referenced
this pull request
Feb 25, 2021
* develop: (232 commits) Add Votings to Open Data export (#7388) Add order in not highlighted assemblies by weight (#7444) Resort Menus (#7460) Polling Officer Zone (#7439) Fix session timeout when using multiple windows or tabs (#7459) Fix display of debates with multiple dates (#7393) chore: split election tests (#7451) style: make selected values primary labels with delete button (#7448) Fix and tests to avoid registered users being invited again (#7392) Migrate Admin menus to Menu Registry (#7368) New Crowdin updates (#7338) Bump to carrierwave 2.2.0 (#7441) Voting: show callout when Polling Stations miss Polling Officers (#7417) Further default orders for the API (#7436) Fix random order inconsistencies (#7437) Ensure Rails is locked to 5.2.4.x series (#7430) Add default order by ID to API list queries (#7424) Update dependencies (#7422) Ignore warning on CI when no artifacts to upload (#7420) Filter and search polling officers (#7411) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Implement Date cell to use in debates in order to correctly display start and end times when the debate start day and end day are different. The logic is the following:
📌 Related Issues
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
📷 Screenshots
Same date
Different date, same year
Different year