Skip to content

Split Election tests suite into 3 workflows#7451

Merged
oriolgual merged 1 commit intodevelopfrom
chore/split-election-tests
Feb 24, 2021
Merged

Split Election tests suite into 3 workflows#7451
oriolgual merged 1 commit intodevelopfrom
chore/split-election-tests

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Feb 23, 2021

🎩 What? Why?

The decidim-elections test suite exceeds 40 minutes to execute in CI, which is at least 10 minutes more than the second-slowest check.

This PR splits the decidim-elections test suite into 3 different actions as previously done for decidim-meetings in #7179.

Testing

Check the execution time for the present PR's checks:

  • Elections (unit tests) -> ~10 minutes
  • Elections (system public) -> ~12 minutes
  • Elections (system admin) -> ~22 minutes

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@orlera orlera force-pushed the chore/split-election-tests branch from f2f807b to 8123aa9 Compare February 23, 2021 15:56
@orlera orlera self-assigned this Feb 23, 2021
@orlera orlera changed the title chore: split election tests Split Election tests suite workflow Feb 23, 2021
@orlera orlera changed the title Split Election tests suite workflow Split Election tests suite into 3 workflows Feb 23, 2021
@orlera orlera marked this pull request as ready for review February 23, 2021 16:47
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Feb 23, 2021

@decidim/mantainers could you review this?

@oriolgual oriolgual merged commit e3ced13 into develop Feb 24, 2021
@oriolgual oriolgual deleted the chore/split-election-tests branch February 24, 2021 07:46
entantoencuanto added a commit that referenced this pull request Feb 25, 2021
* develop: (232 commits)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  Resort Menus (#7460)
  Polling Officer Zone (#7439)
  Fix session timeout when using multiple windows or tabs (#7459)
  Fix display of debates with multiple dates (#7393)
  chore: split election tests (#7451)
  style: make selected values primary labels with delete button (#7448)
  Fix and tests to avoid registered users being invited again (#7392)
  Migrate Admin menus to Menu Registry (#7368)
  New Crowdin updates (#7338)
  Bump to carrierwave 2.2.0 (#7441)
  Voting: show callout when Polling Stations miss Polling Officers (#7417)
  Further default orders for the API (#7436)
  Fix random order inconsistencies (#7437)
  Ensure Rails is locked to 5.2.4.x series (#7430)
  Add default order by ID to API list queries (#7424)
  Update dependencies (#7422)
  Ignore warning on CI when no artifacts to upload (#7420)
  Filter and search polling officers (#7411)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants