🎩 What? Why?

• Move the API default order adding implemented in Add default order by ID to API list queries #7424 to its own module
• Apply the default order also for the Decidim::Core::ComponentList class
• Apply the default order also for the Decidim::Core::ParticipatorySpaceListBase class
• Update the related tests to expect the correct order

This also removes redundant tests from decidim-participatory_processes/spec/lib/query_extensions_spec.rb :

• describe "participatoryProcesses" do

  • decidim/decidim-participatory_processes/spec/lib/query_extensions_spec.rb

    Lines 11 to 23 in ff3e693

    	describe "participatoryProcesses" do
    	let!(:process1) { create(:participatory_process, organization: current_organization) }
    	let!(:process2) { create(:participatory_process, organization: current_organization) }
    	let!(:process3) { create(:participatory_process) }
    	let(:query) { %({ participatoryProcesses { id }}) }
    	it "returns all the processes" do
    	expect(response["participatoryProcesses"]).to include("id" => process1.id.to_s)
    	expect(response["participatoryProcesses"]).to include("id" => process2.id.to_s)
    	expect(response["participatoryProcesses"]).not_to include("id" => process3.id.to_s)
    	end
    	end

  • decidim/decidim-participatory_processes/spec/lib/query_extensions_spec.rb

    Lines 47 to 59 in ff3e693

    	describe "participatoryProcesses" do
    	let!(:process1) { create(:participatory_process, organization: current_organization) }
    	let!(:process2) { create(:participatory_process, organization: current_organization) }
    	let!(:process3) { create(:participatory_process) }
    	let(:query) { %({ participatoryProcesses { id }}) }
    	it "returns all the processes" do
    	expect(response["participatoryProcesses"]).to include("id" => process1.id.to_s)
    	expect(response["participatoryProcesses"]).to include("id" => process2.id.to_s)
    	expect(response["participatoryProcesses"]).not_to include("id" => process3.id.to_s)
    	end
    	end

• describe "participatoryProcess" do

  • decidim/decidim-participatory_processes/spec/lib/query_extensions_spec.rb

    Lines 25 to 45 in ff3e693

    	describe "participatoryProcess" do
    	let(:query) { %({ participatoryProcess(id: \"#{id}\") { id }}) }
    	context "with a participatory process that belongs to the current organization" do
    	let!(:process) { create(:participatory_process, organization: current_organization) }
    	let(:id) { process.id }
    	it "returns the process" do
    	expect(response["participatoryProcess"]).to eq("id" => process.id.to_s)
    	end
    	end
    	context "with a participatory process of another organization" do
    	let!(:process) { create(:participatory_process) }
    	let(:id) { process.id }
    	it "returns nil" do
    	expect(response["participatoryProcess"]).to be_nil
    	end
    	end
    	end

  • decidim/decidim-participatory_processes/spec/lib/query_extensions_spec.rb

    Lines 61 to 81 in ff3e693

    	describe "participatoryProcess" do
    	let(:query) { %({ participatoryProcess(id: \"#{id}\") { id }}) }
    	context "with a participatory process that belongs to the current organization" do
    	let!(:process) { create(:participatory_process, organization: current_organization) }
    	let(:id) { process.id }
    	it "returns the process" do
    	expect(response["participatoryProcess"]).to eq("id" => process.id.to_s)
    	end
    	end
    	context "with a participatory process of another organization" do
    	let!(:process) { create(:participatory_process) }
    	let(:id) { process.id }
    	it "returns nil" do
    	expect(response["participatoryProcess"]).to be_nil
    	end
    	end
    	end

We don't need the same test twice.

📌 Related Issues

• Related to Add default order by ID to API list queries #7424

Testing

See #7424.

📋 Checklist

• ❓ CONSIDER adding a unit test if your PR resolves an issue.
• ✔️ DO check open PR's to avoid duplicates.
• ✔️ DO keep pull requests small so they can be easily reviewed.
• ✔️ DO build locally before pushing.
• ✔️ DO make sure tests pass.
• ✔️ DO make sure any new changes are documented in docs/.
• ✔️ DO add and modify seeds if necessary.
• ✔️ DO add CHANGELOG upgrade notes if required.
• ✔️ DO add to GraphQL API if there are new public fields.
• ✔️ DO add link to MetaDecidim if it's a new feature.
• ❌AVOID breaking the continuous integration build.
• ❌AVOID making significant changes to the overall architecture.