Skip to content

Add Votings to Open Data export#7388

Merged
mrcasals merged 6 commits intodevelopfrom
feat/election-open-data
Feb 25, 2021
Merged

Add Votings to Open Data export#7388
mrcasals merged 6 commits intodevelopfrom
feat/election-open-data

Conversation

@slickepinne
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne commented Feb 15, 2021

🎩 What? Why?

Votings are now exported in Open Data format along with the pre-existent exports.

Since Voting is the first participatory space to implement the open data export, the open_data_exporter service was updated to also consider exporters registered in participatory space manifests.

Also, participatory_space_id and participatory_space_title were added to the election open data export.

N.B.: voting_type is an enum, but still needs to be translated for the export. The translation hash is built by the serializer so the export engine then treats it as a translatable field

📌 Related Issues

Testing

Download the open data files from the footer.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@slickepinne slickepinne self-assigned this Feb 15, 2021
@leio10 leio10 added project: e-voting Barcelona City Council contract module: elections labels Feb 18, 2021
@orlera orlera force-pushed the feat/election-open-data branch from 44e5db9 to 51938b4 Compare February 22, 2021 14:48
@orlera orlera mentioned this pull request Feb 22, 2021
12 tasks
@orlera orlera changed the title Extend election results open data Add Votings to Open Data download Feb 23, 2021
@orlera orlera changed the title Add Votings to Open Data download Add Votings to Open Data export Feb 23, 2021
orlera
orlera previously approved these changes Feb 23, 2021
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! 👐 📅

leio10
leio10 previously approved these changes Feb 23, 2021
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!!! 😍 👏 💎

@orlera orlera dismissed stale reviews from leio10 and themself via 92cdff5 February 24, 2021 11:25
@orlera orlera force-pushed the feat/election-open-data branch 3 times, most recently from 6233b90 to 8932d6c Compare February 24, 2021 15:13
@orlera orlera marked this pull request as ready for review February 24, 2021 15:13
@orlera
Copy link
Copy Markdown
Contributor

orlera commented Feb 24, 2021

@decidim/mantainers this is approved by product and ready to be reviewed 🚀

@mrcasals
Copy link
Copy Markdown
Contributor

@slickepinne there are some conflicts, can you check them please? 😄

@orlera orlera force-pushed the feat/election-open-data branch from 8932d6c to 9a143c2 Compare February 25, 2021 10:36
@orlera
Copy link
Copy Markdown
Contributor

orlera commented Feb 25, 2021

@mrcasals rebased 👍 Thanks for the heads up!

@mrcasals mrcasals self-requested a review February 25, 2021 10:39
@mrcasals
Copy link
Copy Markdown
Contributor

Test looks like a flaky!

@mrcasals mrcasals merged commit 6fe27a3 into develop Feb 25, 2021
@mrcasals mrcasals deleted the feat/election-open-data branch February 25, 2021 13:14
entantoencuanto added a commit that referenced this pull request Feb 25, 2021
* develop: (232 commits)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  Resort Menus (#7460)
  Polling Officer Zone (#7439)
  Fix session timeout when using multiple windows or tabs (#7459)
  Fix display of debates with multiple dates (#7393)
  chore: split election tests (#7451)
  style: make selected values primary labels with delete button (#7448)
  Fix and tests to avoid registered users being invited again (#7392)
  Migrate Admin menus to Menu Registry (#7368)
  New Crowdin updates (#7338)
  Bump to carrierwave 2.2.0 (#7441)
  Voting: show callout when Polling Stations miss Polling Officers (#7417)
  Further default orders for the API (#7436)
  Fix random order inconsistencies (#7437)
  Ensure Rails is locked to 5.2.4.x series (#7430)
  Add default order by ID to API list queries (#7424)
  Update dependencies (#7422)
  Ignore warning on CI when no artifacts to upload (#7420)
  Filter and search polling officers (#7411)
  ...
entantoencuanto added a commit that referenced this pull request Mar 2, 2021
* develop: (25 commits)
  Add css selectors to emails to improve design customization (#7493)
  Only share tokens if component exists (#7499)
  Fix record encryptor hash values JSON parsing for legacy unencrypted hash values (#7494)
  Fix NULL error with weight field in assemblies & processes (#7486)
  Fix proposals to budget import (#7449)
  Fix cost display on proposals (#7450)
  Fix #7487 - Invalid signature on message decryption (#7488)
  New Crowdin updates (#7482)
  Move specs file to correct folder (#7476)
  Improve changelog generator (#7475)
  New Crowdin updates (#7472)
  Prepare 0.25-dev version (#7473)
  New Crowdin updates (#7470)
  New Crowdin updates (#7468)
  Feature proposal infinite edit time (#7406)
  New Crowdin updates (#7457)
  Trigger docs build on folder changes (#7360)
  Add changelog generator based on PR data (#7461)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download results of a voting on an open format (Open Data)

4 participants