Skip to content

Fix NULL error with weight field in assemblies & processes#7486

Merged
mrcasals merged 1 commit intodecidim:developfrom
CodiTramuntana:fix/assembly-process-null-weight
Mar 2, 2021
Merged

Fix NULL error with weight field in assemblies & processes#7486
mrcasals merged 1 commit intodecidim:developfrom
CodiTramuntana:fix/assembly-process-null-weight

Conversation

@laurajaime
Copy link
Copy Markdown
Contributor

@laurajaime laurajaime commented Mar 1, 2021 •
edited
Loading

🎩 What? Why?

An error with the weight in the assemblies and processes forms has been fixed.

A default value(default: 0) and a validation(required field) have been added to the form.

📌 Related Issues

Testing

  1. Sign in as administrator
  2. Go to http://localhost:3000/admin/participatory_processes/new
  3. Fill only the mandatory fields with any string without weight
  4. Save the form
  5. All OK

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@mrcasals mrcasals self-requested a review March 1, 2021 14:16
@mrcasals mrcasals merged commit e243685 into decidim:develop Mar 2, 2021
mrcasals pushed a commit that referenced this pull request Mar 2, 2021
@laurajaime @mrcasals
Fix NULL error with weight field in assemblies & processes (#7486)
0345056
@mrcasals mrcasals mentioned this pull request Mar 2, 2021
Merged
@laurajaime laurajaime mentioned this pull request Mar 2, 2021
Closed
12 tasks
entantoencuanto added a commit that referenced this pull request Mar 2, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
bfdb74b 
* develop: (25 commits)
  Add css selectors to emails to improve design customization (#7493)
  Only share tokens if component exists (#7499)
  Fix record encryptor hash values JSON parsing for legacy unencrypted hash values (#7494)
  Fix NULL error with weight field in assemblies & processes (#7486)
  Fix proposals to budget import (#7449)
  Fix cost display on proposals (#7450)
  Fix #7487 - Invalid signature on message decryption (#7488)
  New Crowdin updates (#7482)
  Move specs file to correct folder (#7476)
  Improve changelog generator (#7475)
  New Crowdin updates (#7472)
  Prepare 0.25-dev version (#7473)
  New Crowdin updates (#7470)
  New Crowdin updates (#7468)
  Feature proposal infinite edit time (#7406)
  New Crowdin updates (#7457)
  Trigger docs build on folder changes (#7360)
  Add changelog generator based on PR data (#7461)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  ...
@tramuntanal tramuntanal deleted the fix/assembly-process-null-weight branch March 4, 2021 11:17
This was referenced Mar 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: assemblies module: participatory processes type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PG:NotNullViolation in ParticipatoryProcesses weight

2 participants

@laurajaime @mrcasals