Skip to content

Fix proposals to budget import#7449

Merged
mrcasals merged 1 commit intodevelopfrom
fix/import_budgets_proposals_cost
Mar 2, 2021
Merged

Fix proposals to budget import#7449
mrcasals merged 1 commit intodevelopfrom
fix/import_budgets_proposals_cost

Conversation

@oriolgual
Copy link
Copy Markdown
Contributor

@oriolgual oriolgual commented Feb 23, 2021

🎩 What? Why?

Continuing the work done by @PierreMesure on #6982 by adding a couple of specs.

📌 Related Issues

Link your PR to an issue

Testing

  • Create a proposal with a cost report and one without
  • Import them in a Budget component
  • Check that the first project has the right cost and the second one has the default budget value.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@PierreMesure
Copy link
Copy Markdown
Contributor

Great work @oriolgual! I'm really not a test engineer so I would have struggled a lot more to finish this PR!

@oriolgual oriolgual force-pushed the fix/import_budgets_proposals_cost branch from 664c624 to 69f0eb3 Compare February 23, 2021 19:25
@mrcasals mrcasals removed their request for review February 24, 2021 09:01
@mrcasals
Copy link
Copy Markdown
Contributor

Removing myself from the reviews until we get the approval from Product (see related issue)

@mrcasals mrcasals added module: budgets type: fix PRs that implement a fix for a bug labels Mar 2, 2021
@mrcasals mrcasals merged commit df45871 into develop Mar 2, 2021
@mrcasals mrcasals deleted the fix/import_budgets_proposals_cost branch March 2, 2021 08:23
entantoencuanto added a commit that referenced this pull request Mar 2, 2021
* develop: (25 commits)
  Add css selectors to emails to improve design customization (#7493)
  Only share tokens if component exists (#7499)
  Fix record encryptor hash values JSON parsing for legacy unencrypted hash values (#7494)
  Fix NULL error with weight field in assemblies & processes (#7486)
  Fix proposals to budget import (#7449)
  Fix cost display on proposals (#7450)
  Fix #7487 - Invalid signature on message decryption (#7488)
  New Crowdin updates (#7482)
  Move specs file to correct folder (#7476)
  Improve changelog generator (#7475)
  New Crowdin updates (#7472)
  Prepare 0.25-dev version (#7473)
  New Crowdin updates (#7470)
  New Crowdin updates (#7468)
  Feature proposal infinite edit time (#7406)
  New Crowdin updates (#7457)
  Trigger docs build on folder changes (#7360)
  Add changelog generator based on PR data (#7461)
  Add Votings to Open Data export (#7388)
  Add order in not highlighted assemblies by weight (#7444)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: budgets type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing proposals into projects uses default budget instead of proposal cost report

3 participants