Define voting type by orlera · Pull Request #7217 · decidim/decidim

orlera · 2021-01-25T14:00:29Z

🎩 What? Why?

Adds a voting_type field to Voting and the related business logic:

From the admin panel, an admin can now:
- Choose which voting type they want when creating/updating a voting;
- Add components to a voting (wasn't yet present);
When a voting is of type "Online" or "Hybrid", a persistent red banner reminds the admin that they need to add at least an election component to the current voting.

Notice that Polling Stations and Polling Station Officers are to be implemented in upcoming tickets (#7105 #7106), so the AC concerning them could not be fulfilled yet (or is inherently fulfilled, depending on the point of view 😉).

📌 Related Issues

Link your PR to an issue

Fixes Define voting type #7104
Related EPIC: Votings [Administrator] #7134

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

♥️ Thank you!

decidim-elections/app/models/decidim/votings/voting.rb

agustibr · 2021-01-28T15:00:24Z

@orlera 👀 🤖 rubocop is offended because of 2 Missing frozen string literal comments 😁

decidim-elections/spec/forms/decidim/votings/admin/voting_form_spec.rb

leio10

Nice! 💎 🚂

leio10 · 2021-01-28T16:39:55Z

decidim-elections/app/models/decidim/votings/voting.rb

+
+      def online_voting?
+        voting_type == "online"
+      end


Should we add an in_person_voting? method?

Hey @leio10!
I guess you were reviewing by commit and didn't notice that that method has been added in a later commit? :)
BTW, I gave a quick shot at enum as you recommended and it was 🤩 until I tried to use it in a select - there for some reason it wasn't able to show the selected option (although it showed the list of options and store the correct one in db when the user selects one).
Might try to give it another spin tomorrow morning 👍

Found some inspiration reviewing @slickepinne's PR to make the enum work in a select 🎉

orlera · 2021-01-29T13:53:53Z

@decidim/mantainers approved by product and ready for review 🎉

beagleknight

Great job! ✨ Just added a few suggestions 👍

decidim-elections/app/constraints/decidim/votings/current_voting.rb

decidim-elections/app/forms/decidim/votings/admin/voting_form.rb

agustibr

Good Work!

agustibr · 2021-02-01T08:09:16Z

decidim-elections/app/models/decidim/votings/voting.rb

      include Decidim::HasAttachments
      include Decidim::HasAttachmentCollections

+      enum voting_type: [:in_person, :online, :hybrid].map { |type| [type, type.to_s] }.to_h, _suffix: :voting


mrcasals · 2021-02-02T08:10:11Z

@orlera there are some conflicts! Ping me when they're solved so I can review it again! :)

…o election component

orlera · 2021-02-02T08:56:55Z

@mrcasals thanks for the heads-up! Rebased with develop, although I didn't get any conflict in my local env... 🤷

mrcasals

Looks good to me, nice job!

orlera force-pushed the feat/define-vonting-type branch from f8fb17f to 95e6609 Compare January 25, 2021 16:01

qlty-cloud-legacy bot reviewed Jan 25, 2021

View reviewed changes

decidim-elections/app/models/decidim/votings/voting.rb Outdated Show resolved Hide resolved

orlera force-pushed the feat/define-vonting-type branch from 95e6609 to 753dde5 Compare January 26, 2021 08:31

orlera changed the base branch from develop to feat/add-votings-attachments January 26, 2021 08:32

orlera linked an issue Jan 26, 2021 that may be closed by this pull request

Define voting type #7104

Closed

5 tasks

orlera self-assigned this Jan 26, 2021

orlera added project: e-voting Barcelona City Council contract space: votings labels Jan 26, 2021

Base automatically changed from feat/add-votings-attachments to develop January 26, 2021 11:01

orlera force-pushed the feat/define-vonting-type branch from 899e1e1 to 7577624 Compare January 27, 2021 10:21

github-actions bot mentioned this pull request Jan 27, 2021

Review app for feat/define-vonting-type by orlera codegram/decidim-staging#281

Closed

orlera force-pushed the feat/define-vonting-type branch 2 times, most recently from f7c67d2 to ff401bc Compare January 27, 2021 14:07

orlera requested review from agustibr, beagleknight, leio10 and slickepinne January 27, 2021 14:09

orlera mentioned this pull request Jan 27, 2021

Define voting type #7104

Closed

5 tasks

orlera force-pushed the feat/define-vonting-type branch from ff401bc to c9cc86e Compare January 27, 2021 15:49

leio10 force-pushed the feat/define-vonting-type branch from 48d34db to 0cdb022 Compare January 28, 2021 11:30

orlera force-pushed the feat/define-vonting-type branch from e7e9282 to 78f7058 Compare January 28, 2021 15:27

qlty-cloud-legacy bot reviewed Jan 28, 2021

View reviewed changes

decidim-elections/spec/forms/decidim/votings/admin/voting_form_spec.rb Outdated Show resolved Hide resolved

orlera force-pushed the feat/define-vonting-type branch from 78f7058 to 33425b8 Compare January 28, 2021 15:33

leio10 previously approved these changes Jan 28, 2021

View reviewed changes

orlera dismissed leio10’s stale review via d076f67 January 29, 2021 08:35

orlera marked this pull request as ready for review January 29, 2021 13:54

beagleknight previously approved these changes Jan 29, 2021

View reviewed changes

decidim-elections/app/constraints/decidim/votings/current_voting.rb Outdated Show resolved Hide resolved

decidim-elections/app/forms/decidim/votings/admin/voting_form.rb Outdated Show resolved Hide resolved

orlera dismissed beagleknight’s stale review via d470414 January 29, 2021 15:41

agustibr previously approved these changes Feb 1, 2021

View reviewed changes

Andrea Orler added 12 commits February 2, 2021 09:54

feat(voting): add voting type field

f886874

feat(voting): create&list components

ce07b29

feat(voting): manage component from admin panel

f8aa708

test(voting): components

e7a1a16

test(voting): system tests

6dbe002

feat(votings): show alert when creating/updating online voting with n…

39a456c

…o election component

fix: show information tab at all time

e18a9b2

feat: move callout to layout

4c8ec21

fix: test

4da70ce

fix: checks

21e5974

feat: use enum for voting_type

fbd6eb2

cr

7c6b66c

orlera dismissed agustibr’s stale review via 7c6b66c February 2, 2021 08:55

orlera force-pushed the feat/define-vonting-type branch from d470414 to 7c6b66c Compare February 2, 2021 08:55

mrcasals approved these changes Feb 2, 2021

View reviewed changes

mrcasals merged commit d443050 into develop Feb 2, 2021

mrcasals deleted the feat/define-vonting-type branch February 2, 2021 09:47

andreslucena pushed a commit that referenced this pull request Feb 3, 2021

Define voting type (#7217)

e92acc4

orlera mentioned this pull request Feb 18, 2021

Voting: show callout when Polling Stations miss Polling Officers #7417

Merged

12 tasks

mrcasals added module: elections type: feature labels Feb 26, 2021

orlera mentioned this pull request Apr 7, 2021

Show missing election component callout also for in-person votings #7809

Merged

12 tasks

Uh oh!

Conversation

orlera commented Jan 25, 2021 • edited by agustibr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📋 Checklist

📷 Screenshots

Uh oh!

Uh oh!

agustibr commented Jan 28, 2021

Uh oh!

Uh oh!

leio10 left a comment

Choose a reason for hiding this comment

Uh oh!

leio10 Jan 28, 2021

Choose a reason for hiding this comment

Uh oh!

orlera Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orlera Jan 29, 2021

Choose a reason for hiding this comment

Uh oh!

orlera commented Jan 29, 2021

Uh oh!

beagleknight left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agustibr left a comment

Choose a reason for hiding this comment

Uh oh!

agustibr Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

mrcasals commented Feb 2, 2021

Uh oh!

orlera commented Feb 2, 2021

Uh oh!

mrcasals left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

orlera commented Jan 25, 2021 •

edited by agustibr

Loading

orlera Jan 28, 2021 •

edited

Loading