Show session timeout warning and limit sessions to 30min of inactivity#7282
Merged
mrcasals merged 47 commits intodecidim:developfrom Feb 11, 2021
Merged
Show session timeout warning and limit sessions to 30min of inactivity#7282mrcasals merged 47 commits intodecidim:developfrom
mrcasals merged 47 commits intodecidim:developfrom
Conversation
* New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian)
Contributor
|
@decidim/product can you review the solution, please? Thanks! |
Member
Contributor
|
@lahdeero can you check the conflicts? Thank you! |
mrcasals
previously approved these changes
Feb 9, 2021
Contributor
|
Nice job, @lahdeero! Let's wait for tests to finish and we'll merge it 😄 |
Contributor
|
@lahdeero I'm sorry, some conflicts appeared and I can't solve them (I guess I don't have permisions to do it because I can't push to your fork). Can you fix them and we'll merge the PR? Thanks! |
Contributor
Author
|
Should be fixed now @mrcasals |
mrcasals
approved these changes
Feb 11, 2021
12 tasks
lahdeero
added a commit
to mainio/decidim
that referenced
this pull request
Feb 16, 2021
This was referenced Feb 24, 2021
12 tasks
oriolgual
pushed a commit
that referenced
this pull request
Mar 5, 2021
* clear interval before unload * Prevent redirect on ajax requests * Cleaning comments and loggers * Add test * Simulate just before session expiration * Test without separate method * Tests for different requests * Trying to get test work in CI * Remove comment * Improve test logic * Update beforeunload * Fix test because session timeout warning: #7282 Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Currently session timeouts when user has been idle for one week! For security reasons it might be better to sign out users when they have been idle for certain time (e.g. 30 minutes). This pull request adds warning for user, who has been idle for too long and will be signed out after 1 minute (after displaying the warning) if user is still not responding.
📌 Related Issues
https://meta.decidim.org/processes/roadmap/f/122/proposals/16220
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots