Skip to content

Add statistics cell to votings landing page and reuse it in other places#7413

Merged
mrcasals merged 21 commits intodevelopfrom
feat/stats_for_public_voting_landing_page
Mar 3, 2021
Merged

Add statistics cell to votings landing page and reuse it in other places#7413
mrcasals merged 21 commits intodevelopfrom
feat/stats_for_public_voting_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 17, 2021 •
edited
Loading

🎩 What? Why?

This PR implements the public side of the Decidim::Votings::ContentBlocks::LandingPage::StatisticsCell.

It also cleans up (stats) views from other modules which where redundant, so its been refactored so all spaces use or inherit from the Decidim::StatisticsCell in favor of maintenance.

Due to this refactor the ConferenceCell stats are updated with the current design/styles.

Plus it adds the elections component to the Voting seeds.

📌 Related Issues

Testing

  • As a participant, visit a voting details page (the statistics cell should be activated from the Landing page admin side):
    Screenshot 2021-02-17 at 16 15 54

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Screnshots from other spaces all look the same as before:

  • Process:
    Screenshot 2021-02-17 at 16 16 37
  • Processes groups:
    Screenshot 2021-02-18 at 07 55 04
  • Assembly:
    Screenshot 2021-02-17 at 16 17 37
  • Organization homepage:
    Screenshot 2021-02-17 at 16 38 30
  • Conference in this pr got a style update:
    Screenshot 2021-02-17 at 16 18 38
  • Conference before:
    Screenshot 2021-02-17 at 16 55 56

♥️ Thank you!

qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Feb 17, 2021
View reviewed changes
@agustibr agustibr changed the title feat(core): statistics and statistic cell Voting statistics cell for the landing page and refactor other spaces to use the Statistics cell Feb 17, 2021
@agustibr agustibr self-assigned this Feb 17, 2021
@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Feb 17, 2021
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch 2 times, most recently from f5efb68 to 1acc6e6 Compare February 23, 2021 09:25
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch from 1acc6e6 to b5e3286 Compare February 23, 2021 09:28
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch from b5e3286 to db67618 Compare February 23, 2021 19:56
@agustibr agustibr changed the base branch from develop to feat/votings_public_landing_page February 23, 2021 19:59
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch from db67618 to fbb1f95 Compare February 25, 2021 15:30
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch 2 times, most recently from 0a229f6 to 9e628cc Compare March 2, 2021 06:52
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch from 9e628cc to 80583b2 Compare March 2, 2021 07:48
@agustibr agustibr marked this pull request as ready for review March 2, 2021 08:54
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch from 80583b2 to db11e0e Compare March 2, 2021 18:36
@agustibr agustibr force-pushed the feat/stats_for_public_voting_landing_page branch from db11e0e to a692ac4 Compare March 3, 2021 07:05
Base automatically changed from feat/votings_public_landing_page to develop March 3, 2021 13:21
@mrcasals mrcasals changed the title Voting statistics cell for the landing page and refactor other spaces to use the Statistics cell Add statistics cell Mar 3, 2021
@mrcasals mrcasals changed the title Add statistics cell Add statistics cell to votings landing page and reuse it in other places Mar 3, 2021
@mrcasals mrcasals merged commit d640192 into develop Mar 3, 2021
@mrcasals mrcasals deleted the feat/stats_for_public_voting_landing_page branch March 3, 2021 15:42
@agustibr
Copy link
Copy Markdown
Contributor Author

agustibr commented Mar 3, 2021

Yuhuuu! Thanks @mrcasals 😄

entantoencuanto added a commit that referenced this pull request Mar 4, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
f882f10 
* develop:
  Update the workflow cleanup action to the latest version (#7535)
  Don't schedule CI jobs for locales PRs (#7534)
  Fix record encryptor trying to decrypt or decode non-String values (#7536)
  Add Votings landing page to the design app (#7527)
  New Crowdin updates (#7530)
  Fix non-unique IDs element in filter hash cash (#7531)
  New Crowdin updates (#7485)
  Add statistics cell to votings landing page and reuse it in other places (#7413)
  Add Votings landing page layout (#7440)
  Add share modal to budgets (#7519)
  Do not change the global test app configs during specs (#7525)
  Change the order of attachments in budgets (#7524)
  Remove console warnings from the conversations views (#7523)
  Don't allow filtering meetings by user group if setting is disabled (#7514)
  Remove duplicated migration (#7517)
  New Admin users cannot accept Terms and conditions (#7516)
  Let installations delay TranslatorJob initialization (#7507)
  Exit on CI workflow dispatch failures (#7502)
  Invalidate all user sessions when destroying the account (#7506)
  Audit vote (#7442)
@ahukkanen ahukkanen mentioned this pull request Mar 4, 2021
Closed
10 tasks
@ahukkanen
Copy link
Copy Markdown
Contributor

ahukkanen commented Mar 4, 2021

I bumped into this looking at the context of the translations and I left a comment at: #7112 (comment)

This removes the possibility to translate the different cases for the statistic title (above or below the number) which is a problem for the Finnish language.

@agustibr
Copy link
Copy Markdown
Contributor Author

agustibr commented Mar 5, 2021

@ahukkanen Thank you very much for the feedback! Highly appreciated. 😀

@andreslucena andreslucena mentioned this pull request Mar 18, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beagleknight beagleknight Awaiting requested review from beagleknight

@leio10 leio10 Awaiting requested review from leio10

@orlera orlera Awaiting requested review from orlera

@slickepinne slickepinne Awaiting requested review from slickepinne

2 more reviewers

@qlty-cloud-legacy qlty-cloud-legacy[bot] qlty-cloud-legacy[bot] left review comments

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

module: assemblies module: conferences module: consultations module: core module: elections module: participatory processes module: sortitions module: surveys project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agustibr @mrcasals @ahukkanen