Skip to content

Add share modal to budgets#7519

Merged
mrcasals merged 1 commit intodevelopfrom
feature/budgets-share
Mar 3, 2021
Merged

Add share modal to budgets#7519
mrcasals merged 1 commit intodevelopfrom
feature/budgets-share

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Adds the share modal to budgets' projects.

Testing

Go to a budget, see share modal

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Before

imatge

After

imatge

♥️ Thank you!

@mrcasals mrcasals merged commit 476979c into develop Mar 3, 2021
@mrcasals mrcasals deleted the feature/budgets-share branch March 3, 2021 13:20
entantoencuanto added a commit that referenced this pull request Mar 4, 2021
* develop:
  Update the workflow cleanup action to the latest version (#7535)
  Don't schedule CI jobs for locales PRs (#7534)
  Fix record encryptor trying to decrypt or decode non-String values (#7536)
  Add Votings landing page to the design app (#7527)
  New Crowdin updates (#7530)
  Fix non-unique IDs element in filter hash cash (#7531)
  New Crowdin updates (#7485)
  Add statistics cell to votings landing page and reuse it in other places (#7413)
  Add Votings landing page layout (#7440)
  Add share modal to budgets (#7519)
  Do not change the global test app configs during specs (#7525)
  Change the order of attachments in budgets (#7524)
  Remove console warnings from the conversations views (#7523)
  Don't allow filtering meetings by user group if setting is disabled (#7514)
  Remove duplicated migration (#7517)
  New Admin users cannot accept Terms and conditions (#7516)
  Let installations delay TranslatorJob initialization (#7507)
  Exit on CI workflow dispatch failures (#7502)
  Invalidate all user sessions when destroying the account (#7506)
  Audit vote (#7442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants