Exit on CI workflow dispatch failures#7502
Merged
Conversation
a0cd63b to
ba7cb8b
Compare
ba7cb8b to
4a354c9
Compare
mrcasals
reviewed
Mar 2, 2021
Comment on lines
+4
to
7
| branches: | ||
| - develop | ||
| paths: | ||
| - 'docs/**' |
Contributor
There was a problem hiding this comment.
I didn't know if this would behave as an OR or as an AND, that's why I restricted it from the step level, but since the job does not appear here it means it works as an AND! Thanks!
mrcasals
approved these changes
Mar 2, 2021
Contributor
|
I noticed the Docker builds were not triggered when the Maybe they didn't trigger because I marked the version as a pre-release? @oliverbarnes |
Contributor
|
Ah, no: it looks like the job was triggered successfully, but it was in a moment when GitHub Actions was semi-down, so it's in a weird state:
All fine, I guess! |
entantoencuanto
added a commit
that referenced
this pull request
Mar 4, 2021
* develop: Update the workflow cleanup action to the latest version (#7535) Don't schedule CI jobs for locales PRs (#7534) Fix record encryptor trying to decrypt or decode non-String values (#7536) Add Votings landing page to the design app (#7527) New Crowdin updates (#7530) Fix non-unique IDs element in filter hash cash (#7531) New Crowdin updates (#7485) Add statistics cell to votings landing page and reuse it in other places (#7413) Add Votings landing page layout (#7440) Add share modal to budgets (#7519) Do not change the global test app configs during specs (#7525) Change the order of attachments in budgets (#7524) Remove console warnings from the conversations views (#7523) Don't allow filtering meetings by user group if setting is disabled (#7514) Remove duplicated migration (#7517) New Admin users cannot accept Terms and conditions (#7516) Let installations delay TranslatorJob initialization (#7507) Exit on CI workflow dispatch failures (#7502) Invalidate all user sessions when destroying the account (#7506) Audit vote (#7442)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Workflow dispatches currently fail silently on error, and their steps show as successful on the CI. This PR configures curl to send an exit signal when that happens, forcing the step to fail.
Also cleans up the branch constraint by removing the conditional and configuring it at the top of the workflow.
📌 Related Issues
In response to #7360 (comment)
Testing
This was tested by switching the workflow to
pull_request, turning off the branch restriction, commenting out the existing curl and running:(there's a new
--fail-with-bodyoption, but it's not available on Github runner's currentcurlversion)To test the actual updated workflow, you can delete the PAT secret to force an auth error.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots