Skip to content

Audit vote#7442

Merged
mrcasals merged 20 commits intodevelopfrom
feature/audit-vote
Mar 2, 2021
Merged

Audit vote#7442
mrcasals merged 20 commits intodevelopfrom
feature/audit-vote

Conversation

@slickepinne
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne commented Feb 23, 2021 •
edited
Loading

🎩 What? Why?

This PR gives the voter the option to audit a vote instead of casting it. When the voter audits the vote, he/she has to start the voting process from the beginning. When auditing, the voter receives a file with the plainvote, encryptedVote and ballotHash. In a later step, this audited vote can get verified.

📌 Related Issues

Testing

Setup an election and do the key ceremony. As soon as the election starts, vote. After confirming, you see the option to audit your vote or to cast it. The ballot hash is given at that point. When auditing a vote, you download the plainvote, plus encrypted vote, plus the ballot hash. To cast a vote after auditing, you have to repeat the voting process.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Audit_vote

♥️ Thank you!

@slickepinne slickepinne self-assigned this Feb 23, 2021
@slickepinne slickepinne marked this pull request as draft February 23, 2021 09:59
qlty-cloud-legacy[bot]
qlty-cloud-legacy bot reviewed Feb 23, 2021
View reviewed changes
@leio10 leio10 added project: e-voting Barcelona City Council contract module: elections labels Feb 23, 2021
orlera
orlera previously approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🔈

leio10
leio10 previously approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great work! ⭐ 💯

beagleknight
beagleknight previously approved these changes Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

@slickepinne slickepinne marked this pull request as ready for review February 26, 2021 15:42
@slickepinne
Copy link
Copy Markdown
Contributor Author

slickepinne commented Mar 1, 2021

Hi @decidim/mantainers, this can get reviewed. :)

agustibr
agustibr previously approved these changes Mar 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Great!

@mrcasals mrcasals merged commit d02c3e8 into develop Mar 2, 2021
@mrcasals mrcasals deleted the feature/audit-vote branch March 2, 2021 15:50
entantoencuanto added a commit that referenced this pull request Mar 4, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
f882f10 
* develop:
  Update the workflow cleanup action to the latest version (#7535)
  Don't schedule CI jobs for locales PRs (#7534)
  Fix record encryptor trying to decrypt or decode non-String values (#7536)
  Add Votings landing page to the design app (#7527)
  New Crowdin updates (#7530)
  Fix non-unique IDs element in filter hash cash (#7531)
  New Crowdin updates (#7485)
  Add statistics cell to votings landing page and reuse it in other places (#7413)
  Add Votings landing page layout (#7440)
  Add share modal to budgets (#7519)
  Do not change the global test app configs during specs (#7525)
  Change the order of attachments in budgets (#7524)
  Remove console warnings from the conversations views (#7523)
  Don't allow filtering meetings by user group if setting is disabled (#7514)
  Remove duplicated migration (#7517)
  New Admin users cannot accept Terms and conditions (#7516)
  Let installations delay TranslatorJob initialization (#7507)
  Exit on CI workflow dispatch failures (#7502)
  Invalidate all user sessions when destroying the account (#7506)
  Audit vote (#7442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

6 more reviewers

@qlty-cloud-legacy qlty-cloud-legacy[bot] qlty-cloud-legacy[bot] left review comments

@mrcasals mrcasals mrcasals approved these changes

@beagleknight beagleknight beagleknight left review comments

@agustibr agustibr agustibr left review comments

@leio10 leio10 leio10 left review comments

@orlera orlera orlera left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@slickepinne slickepinne

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Audit my unsent ballot

6 participants

@slickepinne @beagleknight @agustibr @leio10 @mrcasals @orlera