Merged
Conversation
0c8ba94 to
ef88cd8
Compare
94ff705 to
7498f3e
Compare
ef88cd8 to
a5d42a5
Compare
Base automatically changed from
chore/upgrade-decidim-bulletin-board-to-0.9.1
to
develop
February 9, 2021 07:51
a5d42a5 to
35968de
Compare
b407e29 to
335c771
Compare
b919f26 to
3c131a2
Compare
f53e0f0 to
660bbc4
Compare
3c131a2 to
dce314e
Compare
36ee2c7 to
d91ba43
Compare
61b4e6a to
d76b5a4
Compare
8b2a29c to
cde4448
Compare
d76b5a4 to
389437c
Compare
Contributor
Author
|
@decidim/mantainers, this is ready to be reviewed as well. 😊 |
mrcasals
approved these changes
Mar 2, 2021
| // Use the correct trustee wrapper adapter | ||
| let trusteeWrapperAdapter = null; | ||
|
|
||
| if (schemeName === "dummy") { |
Contributor
There was a problem hiding this comment.
I take it this will be fixed in the future?
Contributor
There was a problem hiding this comment.
Confirmed that this is done on purpose, and will be improved in the future.
Contributor
Author
There was a problem hiding this comment.
This PR uses the DummyTrusteeWrapperAdapter , the next PR by @beagleknight implements the election_guard scheme.
mrcasals
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR gets the results of an
electionwhen thetallyis ended. Inside theadmindashboard, the administrator will see these results. After that, the admin has the option to publish the results. When doing that, the results will be visible to anyone.📌 Related Issues
Testing
Setup an election, finish the key ceremony, voting process and tally. Login as an admin and see the results as soon as the tally is completed. Publish the results and go to the participatory space to which the election belongs. Go to that election and check the results.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots