Skip to content

Invalidate all user sessions when destroying the account#7506

Merged
mrcasals merged 3 commits intodevelopfrom
fix/invalidate-user-sessions-on-account-destroy
Mar 2, 2021
Merged

Invalidate all user sessions when destroying the account#7506
mrcasals merged 3 commits intodevelopfrom
fix/invalidate-user-sessions-on-account-destroy

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals commented Mar 2, 2021

🎩 What? Why?

If you have multiple sessions open (in multiple browsers), and from one of them you delete the account, you're still logged into the other sessions. This causes users to be able to participate, but their name will always appear as "Deleted user". This has been reported in Decidim Barcelona.

This PR invalidates the other sessions after destroying the account.

📌 Related Issues

Builds on top of #5553.

Testing

Ensure CI is green.

@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Mar 2, 2021
@mrcasals mrcasals merged commit 42c4e5d into develop Mar 2, 2021
@mrcasals mrcasals deleted the fix/invalidate-user-sessions-on-account-destroy branch March 2, 2021 16:48
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Mar 2, 2021

This needs to be backported to 0.23 and 0.24

mrcasals added a commit that referenced this pull request Mar 2, 2021
* Invalidate all user sessions when destroying the account

* Add migration to automatically invalidate all sessions for deleted users

* Lint code
mrcasals added a commit that referenced this pull request Mar 2, 2021
* Invalidate all user sessions when destroying the account

* Add migration to automatically invalidate all sessions for deleted users

* Lint code
mrcasals added a commit that referenced this pull request Mar 2, 2021
* Invalidate all user sessions when destroying the account

* Add migration to automatically invalidate all sessions for deleted users

* Lint code
mrcasals added a commit that referenced this pull request Mar 3, 2021
* Invalidate all user sessions when destroying the account

* Add migration to automatically invalidate all sessions for deleted users

* Lint code
entantoencuanto added a commit that referenced this pull request Mar 4, 2021
* develop:
  Update the workflow cleanup action to the latest version (#7535)
  Don't schedule CI jobs for locales PRs (#7534)
  Fix record encryptor trying to decrypt or decode non-String values (#7536)
  Add Votings landing page to the design app (#7527)
  New Crowdin updates (#7530)
  Fix non-unique IDs element in filter hash cash (#7531)
  New Crowdin updates (#7485)
  Add statistics cell to votings landing page and reuse it in other places (#7413)
  Add Votings landing page layout (#7440)
  Add share modal to budgets (#7519)
  Do not change the global test app configs during specs (#7525)
  Change the order of attachments in budgets (#7524)
  Remove console warnings from the conversations views (#7523)
  Don't allow filtering meetings by user group if setting is disabled (#7514)
  Remove duplicated migration (#7517)
  New Admin users cannot accept Terms and conditions (#7516)
  Let installations delay TranslatorJob initialization (#7507)
  Exit on CI workflow dispatch failures (#7502)
  Invalidate all user sessions when destroying the account (#7506)
  Audit vote (#7442)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant