Skip to content

Voting description cell for the landing page #7410

Merged
mrcasals merged 5 commits intofeat/votings_public_landing_pagefrom
feat/description_for_public_voting_landing_page
Mar 2, 2021
Merged

Voting description cell for the landing page #7410
mrcasals merged 5 commits intofeat/votings_public_landing_pagefrom
feat/description_for_public_voting_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 17, 2021 •
edited
Loading

🎩 What? Why?

This PR implements the public side of the Decidim::Votings::ContentBlocks::LandingPage::DescriptionCell.

📌 Related Issues

Testing

  • As a participant, visit a voting details page (the description cell should be activated on the Landing page admin side)
Screen.Recording.2021-02-17.at.12.58.08.mov

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@agustibr agustibr force-pushed the feat/description_for_public_voting_landing_page branch from 820d4dc to 3178339 Compare February 17, 2021 14:41
@agustibr agustibr self-assigned this Feb 17, 2021
@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Feb 17, 2021
@agustibr agustibr force-pushed the feat/description_for_public_voting_landing_page branch 3 times, most recently from b78fe6b to ce00f57 Compare February 23, 2021 19:55
@agustibr agustibr changed the base branch from develop to feat/votings_public_landing_page February 23, 2021 19:58
@agustibr agustibr force-pushed the feat/description_for_public_voting_landing_page branch from ce00f57 to 6a6e498 Compare February 23, 2021 21:44
@agustibr agustibr force-pushed the feat/description_for_public_voting_landing_page branch 2 times, most recently from f769999 to 2ecd577 Compare February 25, 2021 14:28
@agustibr agustibr force-pushed the feat/description_for_public_voting_landing_page branch from 2ecd577 to 63d5594 Compare February 25, 2021 15:47
@agustibr agustibr marked this pull request as ready for review February 25, 2021 16:59
leio10
leio10 approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

orlera
orlera approved these changes Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🇹🇬

slickepinne
slickepinne approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just left a tiny comment. 😊

decidim-elections/app/assets/javascripts/decidim/votings/voting-description-cell.js.es6 Outdated

let $button = $(".voting-description-cell .content-height-toggler .button");
let $content = $button.closest(".voting-description-cell").find(".content");
let $contentContentMaxHeight = remToPx(7.8);
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use contentMaxHeight instead of contentContentMaxHeight here?

mrcasals
mrcasals approved these changes Mar 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! We can probably generalize that in the future to reuse it in other places!

@mrcasals mrcasals merged commit 4b8e54c into feat/votings_public_landing_page Mar 2, 2021
@mrcasals mrcasals deleted the feat/description_for_public_voting_landing_page branch March 2, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beagleknight beagleknight Awaiting requested review from beagleknight

4 more reviewers

@leio10 leio10 leio10 approved these changes

@mrcasals mrcasals mrcasals approved these changes

@orlera orlera orlera approved these changes

@slickepinne slickepinne slickepinne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agustibr @leio10 @mrcasals @orlera @slickepinne