Skip to content

Manage voting landing page with content blocks#7331

Merged
mrcasals merged 2 commits intodevelopfrom
feat/manage_voting_landing_content_blocks
Feb 16, 2021
Merged

Manage voting landing page with content blocks#7331
mrcasals merged 2 commits intodevelopfrom
feat/manage_voting_landing_content_blocks

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 9, 2021

🎩 What? Why?

Implements the admin part to manage voting's landing page with content blocks.

Sets the base for #7112, more PRs for the same issue will come shortly implementing the public side, in this PR the cells/decidim/votings/content_blocks/landing_page/*_cell.rb are just a placeholder.

This PR adds the LandingPage and LandingPageContentBlocks concerns with shared views, in another PR I'll refactor the ParticipatoryProcessGroups LandingPage to use this concern, and probably the same concern with minor changes can be used to manage the Organization's Homepage.

📌 Related Issues

Link your PR to an issue

🧪 Testing & 📷 Screenshots

  • Log in as an admin and go to admin/votings, edit a voting. Click in the "Landing Page" secondary nav entry, to manage it:
    Screenshot 2021-02-11 at 17 39 31

  • Drag'n'drop to activate/deactivate each block, and click in the pencil icon to edit the block (if available):
    Screenshot 2021-02-11 at 17 41 23

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@agustibr agustibr self-assigned this Feb 9, 2021
@agustibr agustibr force-pushed the feat/manage_voting_landing_content_blocks branch 2 times, most recently from ce80cdf to 37d6fa9 Compare February 10, 2021 11:37
@agustibr agustibr linked an issue Feb 10, 2021 that may be closed by this pull request
10 tasks
@agustibr agustibr force-pushed the feat/manage_voting_landing_content_blocks branch 6 times, most recently from 8653cf5 to 8268bf7 Compare February 11, 2021 17:08
@agustibr agustibr marked this pull request as ready for review February 11, 2021 17:45
@agustibr agustibr force-pushed the feat/manage_voting_landing_content_blocks branch 2 times, most recently from 7da6dd6 to 169dce1 Compare February 12, 2021 14:00
orlera
orlera previously approved these changes Feb 15, 2021
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat job! 🧱

leio10
leio10 previously approved these changes Feb 15, 2021
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪

module Decidim
module Admin
module LandingPage
extend ActiveSupport::Concern
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice refactor! 👏👏

@agustibr agustibr dismissed stale reviews from leio10 and orlera via b9fc1a4 February 15, 2021 16:33
@agustibr agustibr force-pushed the feat/manage_voting_landing_content_blocks branch from 169dce1 to b9fc1a4 Compare February 15, 2021 16:33
@agustibr
Copy link
Copy Markdown
Contributor Author

@decidim/mantainers this is ready to be reviewed, as stated in the PR's description this is the base for next PR's where public contents will be added and reviewed by product.

This PR adds the LandingPage concern here applied to Votings and in #7361 is applied to ParticipatoryProcessesGroupsLandingPage where is refactored to use the LandingPage concern.

Thanks 😄

@mrcasals mrcasals merged commit b2aac44 into develop Feb 16, 2021
@mrcasals mrcasals deleted the feat/manage_voting_landing_content_blocks branch February 16, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

See a voting landing

4 participants