Skip to content

Refactor participatory process groups landing page in Admin Dashboard#7361

Merged
mrcasals merged 3 commits intodevelopfrom
chore/manage_ppgroups_landing_content_blocks
Feb 17, 2021
Merged

Refactor participatory process groups landing page in Admin Dashboard#7361
mrcasals merged 3 commits intodevelopfrom
chore/manage_ppgroups_landing_content_blocks

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 12, 2021

🎩 What? Why?

This PR refactors the admin side of ParticpatoryProcesessGroups landing page that manages content blocks to use the LandingPage concern created for Votings in PR #7331.

It also adds active content blocks to the seeds.

📌 Related Issues

Testing

There are No changes for the end user.

  1. Go to the admin dashboard > participatory processes > groups > click group name to edit > click on Landing page in the secondary nav > Manage the content blocks.
  2. Go to the public view of the Participatory Process Group.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Screenshot 2021-02-12 at 19 50 15

♥️ Thank you!

@agustibr agustibr force-pushed the chore/manage_ppgroups_landing_content_blocks branch from bfa4ab3 to eb15faf Compare February 12, 2021 18:31
@agustibr agustibr self-assigned this Feb 12, 2021
@agustibr agustibr changed the title chore(process_groups): refactor landing page admin to use the concern Refactor participatory process groups landing page in Admin Dashboard Feb 12, 2021
@agustibr agustibr force-pushed the feat/manage_voting_landing_content_blocks branch from 169dce1 to b9fc1a4 Compare February 15, 2021 16:33
@agustibr agustibr force-pushed the chore/manage_ppgroups_landing_content_blocks branch from eb15faf to 0d93725 Compare February 16, 2021 08:03
Base automatically changed from feat/manage_voting_landing_content_blocks to develop February 16, 2021 08:20
@agustibr agustibr force-pushed the chore/manage_ppgroups_landing_content_blocks branch from 0d93725 to c63cd79 Compare February 16, 2021 08:39
@agustibr agustibr marked this pull request as ready for review February 16, 2021 17:46
@agustibr
Copy link
Copy Markdown
Contributor Author

@decidim/mantainers this is ready to review 😃

Thanks!

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Thank you!

@mrcasals mrcasals merged commit df67a6f into develop Feb 17, 2021
@mrcasals mrcasals deleted the chore/manage_ppgroups_landing_content_blocks branch February 17, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants