Voting header cell for the landing page#7427
Merged
mrcasals merged 3 commits intofeat/votings_public_landing_pagefrom Mar 2, 2021
Merged
Voting header cell for the landing page#7427mrcasals merged 3 commits intofeat/votings_public_landing_pagefrom
mrcasals merged 3 commits intofeat/votings_public_landing_pagefrom
Conversation
fb69975 to
5ccab29
Compare
1a48786 to
e61e798
Compare
e61e798 to
d97dbc8
Compare
leio10
approved these changes
Feb 25, 2021
| active_item = items.find { |item| item[:active] } | ||
|
|
||
| render partial: "decidim/shared/extended_navigation_bar", locals: { | ||
| render partial: "decidim/shared/extended_navigation_bar.html", locals: { |
Contributor
There was a problem hiding this comment.
Why do we need to add the extension? 🤔
Contributor
Author
There was a problem hiding this comment.
It's wierd, but since the partial is called within a cell I needed to add the extension so it could be found and all works then.
There's another PR for this landing page that needed the same, maybe there's another workaround.
| </section> | ||
|
|
||
| <section class="section"> | ||
| <%= extended_navigation_bar(navigation_items) %> |
Contributor
There was a problem hiding this comment.
The navigation bar is not in the PR screenshot, but it will be there, right?
Contributor
Author
There was a problem hiding this comment.
Yes, it has the participatory space nav bar.
I've updated the screenshot.
mrcasals
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements the public side of the
Decidim::Votings::ContentBlocks::LandingPage::HeaderCell.Adds a setting form to the admin to configure the CTA button from the header.
📌 Related Issues
Testing
As a participant, visit a voting details page (the header cell should be activated from the Landing page admin side):
As an admin, go to manage the voting landing page, and click on the pencil button to edit the cta contents:
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
