Replace partials with the cells they render#7251
Merged
Conversation
bf374cf to
f082aaf
Compare
f082aaf to
771ca2c
Compare
771ca2c to
7f5cc58
Compare
7f5cc58 to
5bb26c0
Compare
oriolgual
approved these changes
Feb 2, 2021
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As described in #7250, some partials only render a cell without any logic check. In these cases, we'd better use the cell directly and we'll avoid the extra render.
📌 Related Issues
Testing
Test suite should be green.