Skip to content

Voting polling stations cell for the landing page#7428

Merged
mrcasals merged 4 commits intofeat/votings_public_landing_pagefrom
feat/polling_stations_for_public_voting_landing_page
Mar 3, 2021
Merged

Voting polling stations cell for the landing page#7428
mrcasals merged 4 commits intofeat/votings_public_landing_pagefrom
feat/polling_stations_for_public_voting_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 19, 2021 •
edited
Loading

🎩 What? Why?

This PR implements the public side of the Decidim::Votings::ContentBlocks::LandingPage::PollingStationsCell.

It also adds polling stations seed data for votings (hybrid and in_person).

📌 Related Issues

Testing

  • As a participant, visit a voting (hybrid or in_person type) landing page (the Polling stations cell should be activated from the Landing page admin side):
    Screenshot 2021-02-25 at 16 52 58
    Screenshot 2021-02-26 at 13 03 59

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Feb 19, 2021
@agustibr agustibr self-assigned this Feb 19, 2021
@agustibr agustibr force-pushed the feat/polling_stations_for_public_voting_landing_page branch from 121488b to 7a166fd Compare February 25, 2021 14:10
@agustibr agustibr changed the base branch from develop to feat/votings_public_landing_page February 25, 2021 14:21
@agustibr agustibr changed the title [wip] Voting polling stations cell for the landing page Voting polling stations cell for the landing page Feb 25, 2021
@agustibr agustibr force-pushed the feat/polling_stations_for_public_voting_landing_page branch 2 times, most recently from e184d3f to 60b5171 Compare February 25, 2021 15:51
@agustibr agustibr marked this pull request as ready for review February 25, 2021 17:00
leio10
leio10 approved these changes Feb 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

beagleknight
beagleknight approved these changes Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

orlera
orlera approved these changes Feb 26, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 🗺️

slickepinne
slickepinne approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just be careful with the word address 😄

...elections/app/cells/decidim/votings/content_blocks/landing_page/polling_stations/address.erb Outdated
@@ -0,0 +1,14 @@
<div class="polling_station-addres">
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="polling_station-addres">
<div class="polling_station-address">

😊

Copy link
Copy Markdown
Contributor Author

@agustibr agustibr Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅 I'll fix it, thanks

...dim-elections/app/cells/decidim/votings/content_blocks/landing_page/polling_stations/map.erb Outdated
<div>
<h3>${title}</h3>
<div id="bodyContent">
<div class="map__date-adress">
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="map__date-adress">
<div class="map__date-address">

Copy link
Copy Markdown
Contributor Author

@agustibr agustibr Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😓

Copy link
Copy Markdown
Contributor

@slickepinne slickepinne Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, that word is really mean. 😂

@agustibr agustibr force-pushed the feat/polling_stations_for_public_voting_landing_page branch from d28e01f to ba32fcb Compare March 2, 2021 18:07
@agustibr agustibr force-pushed the feat/polling_stations_for_public_voting_landing_page branch from ba32fcb to 31e7c46 Compare March 3, 2021 07:03
@mrcasals mrcasals merged commit 9effc9b into feat/votings_public_landing_page Mar 3, 2021
@mrcasals mrcasals deleted the feat/polling_stations_for_public_voting_landing_page branch March 3, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@slickepinne slickepinne slickepinne approved these changes

@beagleknight beagleknight beagleknight approved these changes

@leio10 leio10 leio10 approved these changes

@mrcasals mrcasals mrcasals approved these changes

@orlera orlera orlera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@agustibr agustibr

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@agustibr @beagleknight @leio10 @mrcasals @orlera @slickepinne