Voting metrics cell for the landing page#7469
Merged
mrcasals merged 2 commits intofeat/votings_public_landing_pagefrom Mar 3, 2021
Merged
Voting metrics cell for the landing page#7469mrcasals merged 2 commits intofeat/votings_public_landing_pagefrom
mrcasals merged 2 commits intofeat/votings_public_landing_pagefrom
Conversation
5442165 to
8fc58db
Compare
8fc58db to
f74cfc3
Compare
slickepinne
approved these changes
Mar 1, 2021
| def metrics | ||
| nil | ||
|
|
||
| # @metrics ||= VotingsMetricChartsPresenter.new(participatory_process: current_participatory_space) |
Contributor
There was a problem hiding this comment.
Is this comment needed? 😊
Contributor
Author
There was a problem hiding this comment.
No, it is just a hint for when the metrics are available. 😁
f74cfc3 to
f8004ab
Compare
f8004ab to
cfffb3b
Compare
…_public_voting_landing_page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR implements the public side of the
Decidim::Votings::ContentBlocks::LandingPage::MetricsCell.Currently there are no metrics implemented for the votings space so this
cellis just a placeholder for the metrics to be defined in the future.📌 Related Issues
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.