Skip to content

Voting elections cell for the landing page#7423

Merged
mrcasals merged 4 commits intofeat/votings_public_landing_pagefrom
feat/elections_for_public_voting_landing_page
Mar 2, 2021
Merged

Voting elections cell for the landing page#7423
mrcasals merged 4 commits intofeat/votings_public_landing_pagefrom
feat/elections_for_public_voting_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 19, 2021

🎩 What? Why?

This PR implements the public side of the Decidim::Votings::ContentBlocks::LandingPage::ElectionsCell.

📌 Related Issues

Testing

  • As a participant, visit a voting details page (the elections' cell should be activated from the Landing page admin side):
    • Elections' cards will be shown when many elections are published:
    Screenshot 2021-03-01 at 11 42 42 - and when only a **single election** is published, question previews or results will be shown with a vote button. Screenshot 2021-02-19 at 09 04 03 Screenshot 2021-02-19 at 09 04 34

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@agustibr agustibr self-assigned this Feb 19, 2021
@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Feb 19, 2021
@agustibr agustibr force-pushed the feat/elections_for_public_voting_landing_page branch from d1a128f to 940866e Compare February 23, 2021 19:57
@agustibr agustibr changed the base branch from develop to feat/votings_public_landing_page February 23, 2021 20:00
@agustibr agustibr force-pushed the feat/elections_for_public_voting_landing_page branch from 940866e to 4b2473f Compare February 26, 2021 11:41
@agustibr agustibr force-pushed the feat/elections_for_public_voting_landing_page branch from 4b2473f to 2f3fbc8 Compare February 26, 2021 15:11
@agustibr agustibr force-pushed the feat/elections_for_public_voting_landing_page branch from 2f3fbc8 to 17e2021 Compare February 26, 2021 16:06
@agustibr agustibr marked this pull request as ready for review March 2, 2021 07:48
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mrcasals mrcasals merged commit d64982c into feat/votings_public_landing_page Mar 2, 2021
@mrcasals mrcasals deleted the feat/elections_for_public_voting_landing_page branch March 2, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants