Skip to content

Voting timeline cell for the landing page#7453

Merged
mrcasals merged 2 commits intofeat/votings_public_landing_pagefrom
feat/timeline_for_public_voting_landing_page
Mar 3, 2021
Merged

Voting timeline cell for the landing page#7453
mrcasals merged 2 commits intofeat/votings_public_landing_pagefrom
feat/timeline_for_public_voting_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 23, 2021

🎩 What? Why?

This PR implements the Decidim::Votings::ContentBlocks::LandingPage::TimelineCell.

The HTML and CSS code has to be typed/pasted in the edit form from the admin side.

📌 Related Issues

Testing

  • As a participant, visit a voting details page (the timeline cell should be activated on the Landing page admin side):
    Screenshot 2021-02-23 at 19 47 12
  • As an admin, go to manage the voting LandingPage, edit and activate the timeline block:
    Screenshot 2021-02-23 at 19 46 20

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@agustibr agustibr self-assigned this Feb 23, 2021
@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Feb 23, 2021
@agustibr agustibr changed the base branch from develop to feat/votings_public_landing_page February 23, 2021 18:49
@agustibr agustibr force-pushed the feat/votings_public_landing_page branch from 17a8abb to 6ca484c Compare February 23, 2021 19:53
@agustibr agustibr force-pushed the feat/timeline_for_public_voting_landing_page branch 3 times, most recently from 4246dcd to 3a81980 Compare February 26, 2021 15:17
@agustibr agustibr marked this pull request as ready for review February 26, 2021 15:43
Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⌛ 📏

Copy link
Copy Markdown
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agustibr agustibr force-pushed the feat/timeline_for_public_voting_landing_page branch from 3a81980 to 9fbc7f1 Compare March 2, 2021 18:09
@agustibr agustibr force-pushed the feat/timeline_for_public_voting_landing_page branch from 9fbc7f1 to 9c5ecc5 Compare March 3, 2021 06:56
@mrcasals mrcasals merged commit ab04e12 into feat/votings_public_landing_page Mar 3, 2021
@mrcasals mrcasals deleted the feat/timeline_for_public_voting_landing_page branch March 3, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants