Skip to content

Voting attachments and folders cell for the landing page#7418

Merged
mrcasals merged 1 commit intofeat/votings_public_landing_pagefrom
feat/attachments_for_public_voting_landing_page
Mar 2, 2021
Merged

Voting attachments and folders cell for the landing page#7418
mrcasals merged 1 commit intofeat/votings_public_landing_pagefrom
feat/attachments_for_public_voting_landing_page

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

@agustibr agustibr commented Feb 18, 2021

🎩 What? Why?

This PR implements the public side of the Decidim::Votings::ContentBlocks::LandingPage::AttachmentsAndFoldersCell.

The core partials used relative paths (also for translation strings) and have been changed to absolute, so they could be used within the cell.

📌 Related Issues

Testing

  • As a participant, visit a voting details page (the attachments cell should be activated on the Landing page admin side)
    Screenshot 2021-02-18 at 11 08 17

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@agustibr agustibr self-assigned this Feb 18, 2021
@agustibr agustibr added project: e-voting Barcelona City Council contract module: elections labels Feb 18, 2021
@agustibr agustibr force-pushed the feat/attachments_for_public_voting_landing_page branch from 1c43f51 to 5ef8905 Compare February 23, 2021 19:56
@agustibr agustibr changed the base branch from develop to feat/votings_public_landing_page February 23, 2021 19:59
@agustibr agustibr force-pushed the feat/attachments_for_public_voting_landing_page branch from 5ef8905 to 0ef7665 Compare February 25, 2021 16:05
@agustibr agustibr marked this pull request as ready for review February 25, 2021 17:00
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍
Just one doubt: why do we need to add the full path and extensions to the partials?

Copy link
Copy Markdown
Contributor

@orlera orlera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜

Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agustibr
Copy link
Copy Markdown
Contributor Author

@leio10 I had to add the extension to the partials, because with out it's not working the call from the cell to helper to the partial.

@agustibr agustibr force-pushed the feat/attachments_for_public_voting_landing_page branch from 0ef7665 to c47ffec Compare February 26, 2021 15:08
@agustibr agustibr force-pushed the feat/attachments_for_public_voting_landing_page branch from c47ffec to e5defc8 Compare March 2, 2021 07:56
@mrcasals mrcasals merged commit 1801780 into feat/votings_public_landing_page Mar 2, 2021
@mrcasals mrcasals deleted the feat/attachments_for_public_voting_landing_page branch March 2, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants