Closed
Conversation
Co-authored-by: Servon <zewen.li@polixir.ai>
Co-authored-by: Max Fitton <max@semprehealth.com>
…1431) * support hierarchical search spaces for hyperopt * Reduce num samples * Fix prefix
) This reverts commit 3ed3dea.
…roject#11306) * add GUARDED_BY for success_placement_groups_ and failure_placement_groups_ vector * update lint * update lint * update logical * update lint * change int to unsigned int * update lint * rename vector_mutex_ to placement_group_requests_mutex_ * resolve comment * add int() for windows
…)" (ray-project#11502) This reverts commit f500292.
…euse the dashboard port (ray-project#11487) Co-authored-by: Allen Yin <allenyin@anyscale.io>
Co-authored-by: 灵洵 <fengbin.ffb@antfin.com>
Co-authored-by: Servon <zewen.li@polixir.ai> Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: xujiqiang eigen <xujiqiang@hpc1.ipa.aidigger.com>
…s exited (ray-project#11493) * Allow creating tasks/actors in a detached actor when driver has exited * lint * Address comment
* wip * fix * deprecate
* defleked * lint * . * Update cluster_task_manager_test.cc Co-authored-by: Alex Wu <alex@anyscale.com>
* update dashboard to work if GPU utilization field is missing from GPU payload * lint * lint
* Update infeasible actor UI so that it only shows infeasible for an ActorClassGroup if at least one actor in the class is infeasible * lint
* fix * Added comment Co-authored-by: Alex Wu <alex@anyscale.com>
* In progress. Done with all placement group manager code. * It is working with job. * Finished detached actor implementation. * Fix minor issue. * In progress. * Addressed code review. * Addressed code review. * Addressed code reivew. * Fix a build error.
…ter configs with new properties. (ray-project#11693)
* Finished the first iteration. * Removed unnecessary code. * Smartopen impl. * Make sure tests passed. * Addressed code review. * Addressed code review. * Fix issues. * Fix issues.
* fix get_worker_table bug * fix lint * fix comment * remove actor table * fix comment * fix get alive worker * remove unused python import
* Fix large json test file. * Fix large json test file. * WIP.
…into serve-dep-mgmt
7 tasks
architkulkarni
pushed a commit
that referenced
this pull request
Dec 2, 2020
* WIP. * Fix. * Fix. * Fix.
architkulkarni
pushed a commit
that referenced
this pull request
Dec 28, 2020
architkulkarni
pushed a commit
that referenced
this pull request
Dec 29, 2020
…unicator caching (ray-project#12935) * other collectives all work * auto-linting * mannual linting #1 * mannual linting 2 * bugfix * add send/recv point-to-point calls * add some initial code for communicator caching * auto linting * optimize imports * minor fix * fix unpassed tests * support more dtypes * rerun some distributed tests for send/recv * linting
architkulkarni
pushed a commit
that referenced
this pull request
Sep 15, 2021
architkulkarni
pushed a commit
that referenced
this pull request
Sep 16, 2021
architkulkarni
pushed a commit
that referenced
this pull request
Jan 14, 2022
architkulkarni
pushed a commit
that referenced
this pull request
Jul 27, 2022
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is: ``` #0 0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /lib64/libstdc++.so.6 #1 0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so #2 0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so #3 0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so #4 0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so #5 0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so #6 0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2 #7 0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2 #8 0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2 #9 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6 #10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2 #11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2 #12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6 #13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6 #14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2 #15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2 #16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>) at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369 ``` The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`). It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`. The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though. BTW, I've tried different approaches: 1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well. 2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
architkulkarni
pushed a commit
that referenced
this pull request
Nov 20, 2023
architkulkarni
pushed a commit
that referenced
this pull request
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.