[Dashboard] Make Infeasible Actor UX Less Scary#11654
Merged
rkooo567 merged 2 commits intoray-project:masterfrom Oct 30, 2020
Merged
[Dashboard] Make Infeasible Actor UX Less Scary#11654rkooo567 merged 2 commits intoray-project:masterfrom
rkooo567 merged 2 commits intoray-project:masterfrom
Conversation
…torClassGroup if at least one actor in the class is infeasible
rkooo567
approved these changes
Oct 28, 2020
Contributor
rkooo567
left a comment
There was a problem hiding this comment.
There's a lint failure. Btw, do you think it makes sense to put infeasible section at the bottom instead of the top? I think there's still an issue with the current UI that the GPUActor is completely infeasible although, in reality, there are only subsets of GPU actors that are infeasible. I think the issue is the infeasible draw my attention too much, and I evaluated that the whole GPUActor is the infeasible without looking at other sections like Alive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This updates the infeasible actor UI in the logical view so that the "Infeasible" data point for a given actor class will only be displayed if there is at least one actor of that class which is infeasible. It used to be always displayed.
Related issue number
None.
Checks
scripts/format.shto lint the changes in this PR.Manually QA'd like other dashboard front-end changes :/