[Java] fix shutdown lock typo#11410
Merged
kfstorm merged 2 commits intoray-project:masterfrom Oct 20, 2020
Merged
Conversation
ffbin
reviewed
Oct 16, 2020
| @Override | ||
| public void shutdown() { | ||
| Lock writeLock = shutdownLock.readLock(); | ||
| Lock writeLock = shutdownLock.writeLock(); |
Contributor
There was a problem hiding this comment.
Two questions:
- Will
shutdownbe called by multithreading? - Why there is no problem with UT?
Member
Author
There was a problem hiding this comment.
-
shutdownwon't be called concurrently, but the lock is also used inNativeObjectStore. When an object is GCed, the object will be unregistered from core worker. Since GC runs in a separate thread, we need to make sure that core worker is available whenNativeObjectStoreis accessing core worker in the GC thread. -
There was some occasional failures in ReferenceCountingTest, but since we've added retry recently (like Python tests), it's unlikely to fail 3 times in a test session.
Contributor
There was a problem hiding this comment.
shutdown won't be called concurrently, but the lock is also used in NativeObjectStore. When an object is GCed, the object will be unregistered from core worker. Since GC runs in a separate thread, we need to make sure that core worker is available when NativeObjectStore is accessing core worker in the GC thread.
How about add it to the code comment?
ffbin
approved these changes
Oct 16, 2020
ffbin
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.