[autoscaler] Clean up monitoring loop code#11677
Merged
ericl merged 6 commits intoray-project:masterfrom Oct 30, 2020
Merged
Conversation
wuisawesome
approved these changes
Oct 28, 2020
Contributor
wuisawesome
left a comment
There was a problem hiding this comment.
Looks pretty innocuous so long as the dead code really is dead.
Contributor
|
|
Contributor
|
And also |
wuisawesome
approved these changes
Oct 29, 2020
| address, None, redis_password=ray_constants.REDIS_DEFAULT_PASSWORD) | ||
| monitor.update_raylet_map(_append_port=True) | ||
| monitor.psubscribe(ray.gcs_utils.XRAY_JOB_PATTERN) # TODO: Remove? | ||
| monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL) |
Contributor
There was a problem hiding this comment.
Suggested change
| monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL) |
We can simply remove this as no autoscaler related message should be handled in this test case.
Contributor
Author
|
Ah, the reason I kept that was since an error is raised if there is no
subscriptions at all.
…On Thu, Oct 29, 2020, 12:51 AM Tao Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In python/ray/tests/test_multi_node_2.py
<#11677 (comment)>:
> @@ -68,13 +68,13 @@ def setup_monitor(address):
monitor = Monitor(
address, None, redis_password=ray_constants.REDIS_DEFAULT_PASSWORD)
monitor.update_raylet_map(_append_port=True)
- monitor.psubscribe(ray.gcs_utils.XRAY_JOB_PATTERN) # TODO: Remove?
+ monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL)
⬇️ Suggested change
- monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL)
+ monitor.subscribe(ray.ray_constants.AUTOSCALER_RESOURCE_REQUEST_CHANNEL)
We can simply remove this as no autoscaler related message should be
handled in this test case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11677 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSW6TG4YUZ42ENYUXODSNENIVANCNFSM4TCZRZZA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?