Skip to content

[tune](deps): Bump portalocker from 2.0.0 to 2.3.0 in /python/requirements#10

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/pip/python/requirements/portalocker-2.3.0
Closed

[tune](deps): Bump portalocker from 2.0.0 to 2.3.0 in /python/requirements#10
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/pip/python/requirements/portalocker-2.3.0

Conversation

@dependabot
Copy link
Copy Markdown

@dependabot dependabot bot commented on behalf of github Apr 3, 2021

Bumps portalocker from 2.0.0 to 2.3.0.

Release notes

Sourced from portalocker's releases.

v2.3.0

commit 631352fbfd9f2b780a6d5f9da39646f4088910aa Merge: e99c2d6 ec9f5da Author: Rick van Hattem Wolph@wol.ph Date: Sun Mar 28 04:18:59 2021 +0200

Merge tag 'v2.3.0' into develop

enabled PEP 561 compliance v2.3.0

gpg: Signature made Sun 28 Mar 04:18:59 2021 CEST

gpg: using RSA key 149325FD15904E9C4EB89E95E81444E9CE1F695D

gpg: Good signature from "/Rick van Hattem <wolph@wol.ph>"/ [ultimate]

gpg: aka "/[jpeg image of size 9662]"/ [ultimate]

v2.2.1

commit 638f67af428413ef6b2a45633b6e4f034b11f272 Merge: ad33bc1 061837e Author: Rick van Hattem Wolph@wol.ph Date: Wed Feb 3 02:10:59 2021 +0100

Merge tag 'v2.2.1' into develop

removed debug statement v2.2.1

gpg: Signature made Wed Feb 3 02:10:59 2021 CET

gpg: using RSA key 149325FD15904E9C4EB89E95E81444E9CE1F695D

gpg: Good signature from Rick van Hattem <wolph@wol.ph> [ultimate]

gpg: aka [jpeg image of size 9662] [ultimate]

v2.2.0

commit 3c5ea798a5bb8163a5deabc866934ff3d08b3191 Author: Rick van Hattem Wolph@wol.ph Date: Sat Jan 30 02:27:50 2021 +0100

updated travis location
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 3, 2021
@dependabot @github
Copy link
Copy Markdown
Author

dependabot bot commented on behalf of github May 11, 2021

Looks like portalocker is no longer a dependency, so this is no longer needed.

@dependabot dependabot bot closed this May 11, 2021
@dependabot dependabot bot deleted the dependabot/pip/python/requirements/portalocker-2.3.0 branch May 11, 2021 18:32
architkulkarni pushed a commit that referenced this pull request Jul 27, 2022
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants