[Docker] Set Docker as the Default #11416
Merged
simon-mo merged 3 commits intoray-project:masterfrom Oct 19, 2020
Merged
Conversation
Contributor
Author
|
cc @ray-project/ray-autoscaler |
ericl
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This decouples
example-full.yamlfromdefaults.yaml. The latter is now used to "fill in cluster configs".This PR also makes Docker the default in
example*.yamlRelated issue number
Replaces #11121
Checks
latesttag is safe to use (following [CI] Fix-Up Docker Build (Use Python) #11139-gpuis the default & [Docker] Automagically add "runtime=nvidia" #11125 allow for easy GPU usagescripts/format.shto lint the changes in this PR.