Skip to content

Docker on by default in example-full.yaml; use new defaults.yaml for defaults#11121

Closed
ijrsvt wants to merge 9 commits intoray-project:masterfrom
ijrsvt:docker-default
Closed

Docker on by default in example-full.yaml; use new defaults.yaml for defaults#11121
ijrsvt wants to merge 9 commits intoray-project:masterfrom
ijrsvt:docker-default

Conversation

@ijrsvt
Copy link
Copy Markdown
Contributor

@ijrsvt ijrsvt commented Sep 29, 2020

Why are these changes needed?

Docker is the default now!

Related issue number

Replaces #10934

TODOs (from 10934):

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt force-pushed the docker-default branch 2 times, most recently from 69f4eb4 to d8425c8 Compare October 14, 2020 20:30
@ijrsvt
Copy link
Copy Markdown
Contributor Author

ijrsvt commented Oct 15, 2020

I managed to bork this :/

@ijrsvt ijrsvt closed this Oct 15, 2020
@ijrsvt ijrsvt deleted the docker-default branch October 15, 2020 16:21
@ijrsvt ijrsvt mentioned this pull request Oct 16, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants