[autoscaler] [WIP] Docker on by default in example-full.yaml; use new defaults.yaml for defaults#10934
Closed
ericl wants to merge 5 commits intoray-project:masterfrom
Closed
[autoscaler] [WIP] Docker on by default in example-full.yaml; use new defaults.yaml for defaults#10934ericl wants to merge 5 commits intoray-project:masterfrom
ericl wants to merge 5 commits intoray-project:masterfrom
Conversation
Contributor
Author
Contributor
|
@ericl This approach looks fine, I think you just need to edit the |
Contributor
Author
|
Sounds good. I'll leave this PR to you then (since we can't merge it without testing the configs), or you can copy the branch and make a new PR? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This change enables docker by default in the autoscaler examples. To avoid breaking backwards compatibility for user YAMLs, which inherit from example-full currently, the verbatim contents of the example files has been copied to
defaults.yaml, which is the new default config for node providers. This way, existing user YAML files won't have docker enabled unless they specify it.TODOs: