[CI] Fix-Up Docker Build (Use Python)#11139
Merged
simon-mo merged 31 commits intoray-project:masterfrom Oct 12, 2020
Merged
Conversation
sumanthratna
reviewed
Oct 2, 2020
sumanthratna
reviewed
Oct 2, 2020
Contributor
|
do you think it make sense to use docker's python sdk? https://docker-py.readthedocs.io/en/stable/images.html#docker.models.images.ImageCollection.build |
Co-authored-by: Sumanth Ratna <sumanthratna@gmail.com>
Co-authored-by: Sumanth Ratna <sumanthratna@gmail.com>
6 tasks
Member
sumanthratna
left a comment
There was a problem hiding this comment.
@ijrsvt this looks really nice! I left some post-merge comments on very minor things to change in a later PR. if you want I can push a PR to fix these comments next weekend
Contributor
Author
Thanks so much for the feedback--if you could make a PR with some of the fixes above that would be fantastic! Thanks for taking the time @sumanthratna |
6 tasks
6 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Our current CI Docker building solution is a bash nightmare--this moves it into python so it is more maintainable and reliable.
It also fixes our logic that rebuilds all images when a PR has a non-standard branch name. This also allows us to rebuild & push base images when dependencies change (as opposed to just every 2 weeks).
The new output looks like: this
Related issue number
Checks
scripts/format.shto lint the changes in this PR.