[Serve][Doc] Add FAQ Page#11258
Merged
simon-mo merged 4 commits intoray-project:masterfrom Oct 20, 2020
Merged
Conversation
Move some FAQ page and add more content from feedback at Ray Summit.
simon-mo
commented
Oct 7, 2020
|
|
||
| In this case, Serve will `not` wrap it in ServeRequest. You can directly | ||
| process the request as a ``flask.Request``. | ||
|
|
Contributor
Author
There was a problem hiding this comment.
New content starts here
edoakes
approved these changes
Oct 9, 2020
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this. Just left some wording suggestions.
doc/source/serve/faq.rst
Outdated
| How fast is ray serve? | ||
| ---------------------- | ||
| We are continuously benchmark Ray Serve. We can confidently say Ray Serve's | ||
| overhead is single digit millisecond, often times just 1-2 milliseconds. So |
Collaborator
There was a problem hiding this comment.
Suggested change
| overhead is single digit millisecond, often times just 1-2 milliseconds. So | |
| overhead is single digit milliseconds, often times just 1-2 milliseconds. So |
bllchmbrs
reviewed
Oct 9, 2020
Co-authored-by: Edward Oakes <ed.nmi.oakes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move some FAQ page and add more content from feedback at Ray Summit.
Why are these changes needed?
Closes #10322
Related issue number
Checks
scripts/format.shto lint the changes in this PR.