[Dashboard] Remove .fake build files#11478
Merged
simon-mo merged 1 commit intoray-project:masterfrom Oct 19, 2020
Merged
Conversation
simon-mo
approved these changes
Oct 19, 2020
rkooo567
pushed a commit
that referenced
this pull request
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
These files should not be here now that we build the actual dashboard into the build dir.
Devs building the new dashboard from source will see a git diff with these two files removed, which is undesirable.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.