[GCS]Fix TestActorTableResubscribe bug#11463
Merged
rkooo567 merged 1 commit intoray-project:masterfrom Oct 21, 2020
Merged
Conversation
Contributor
Author
|
Hi @rkooo567 , please help take a look, thanks :) |
Contributor
|
@ffbin Does this mean there will be a DEAD message eventually? If this is not guaranteed, it can cause issues in real app right? |
Contributor
Author
Yeah, there will be a DEAD message in real app. |
rkooo567
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
GCS will not reply when actor registration fails, so when GCS restarts, gcs client will register the actor again. When an actor is registered, the status in GCS is
DEPENDENCIES_UNREADY. When GCS finds that the owner of an actor is nil, it will destroy the actor and the status of the actor will change toDEAD. The GCS client fetch actor info from the GCS server, and the status of the actor may beDEPENDENCIES_UNREADYorDEAD, so we do not assert the actor status here any more.Related issue number
Checks
scripts/format.shto lint the changes in this PR.