[autoscaler/k8s] [minor] Kubernetes rsync verbosity fixed#11716
Merged
ericl merged 1 commit intoray-project:masterfrom Oct 30, 2020
Merged
[autoscaler/k8s] [minor] Kubernetes rsync verbosity fixed#11716ericl merged 1 commit intoray-project:masterfrom
ericl merged 1 commit intoray-project:masterfrom
Conversation
Contributor
Author
|
cc @mkoh-asapp |
ericl
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently,
ray rsyncalways produces verbose output on a Kubernetes cluster. This PR changes the behavior to be more consistent with the other providers -- the output is verbose when copying files specified on the command line but quiet when syncing file mounts.Related issue number
Resolves #11685.
Checks
scripts/format.shto lint the changes in this PR.Kubernetes syncer looks not too spammy when run on local minikube cluster.