Skip to content

Remove unused field in heartbeat message#11459

Merged
ericl merged 2 commits intoray-project:masterfrom
antgroup:rm_unused_field
Oct 21, 2020
Merged

Remove unused field in heartbeat message#11459
ericl merged 2 commits intoray-project:masterfrom
antgroup:rm_unused_field

Conversation

@WangTaoTheTonic
Copy link
Copy Markdown
Contributor

Why are these changes needed?

active_object_id in heartbeat message HeartbeatTableData has not been used in any codes, we can remove it.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl
Copy link
Copy Markdown
Contributor

ericl commented Oct 21, 2020

Dashboard test is timing out, perhaps it is related.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 21, 2020
@WangTaoTheTonic WangTaoTheTonic removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 21, 2020
@WangTaoTheTonic
Copy link
Copy Markdown
Contributor Author

Dashboard test is timing out, perhaps it is related.

Same failures happens in other PRs and it succeed after retry. :)

@ericl ericl merged commit da2d3fb into ray-project:master Oct 21, 2020
@ericl
Copy link
Copy Markdown
Contributor

ericl commented Oct 21, 2020

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants