Skip to content

[Dashboard][Hotfix] Update dashboard build instructions for new dashboard#11471

Merged
simon-mo merged 1 commit intoray-project:masterfrom
mfitton:dash-build-doc-patch
Oct 19, 2020
Merged

[Dashboard][Hotfix] Update dashboard build instructions for new dashboard#11471
simon-mo merged 1 commit intoray-project:masterfrom
mfitton:dash-build-doc-patch

Conversation

@mfitton
Copy link
Copy Markdown
Contributor

@mfitton mfitton commented Oct 19, 2020

Why are these changes needed?

The old dashboard build instructions in building from source do not work for the new dashboard, this fixes that issue.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
Copy link
Copy Markdown
Contributor

Can you also remove these in git so it won't be problem for people building from source in the future?
deleted: dashboard/client/build/.fakebuild
deleted: dashboard/client/build/static/.fakestatic

@simon-mo simon-mo merged commit 79fd1cf into ray-project:master Oct 19, 2020
@mfitton mfitton deleted the dash-build-doc-patch branch October 19, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants