Skip to content

[Dashboard] Fix null gpu utilization#11650

Merged
rkooo567 merged 3 commits intoray-project:masterfrom
mfitton:fix-null-gpu-utilization
Oct 30, 2020
Merged

[Dashboard] Fix null gpu utilization#11650
rkooo567 merged 3 commits intoray-project:masterfrom
mfitton:fix-null-gpu-utilization

Conversation

@mfitton
Copy link
Copy Markdown
Contributor

@mfitton mfitton commented Oct 27, 2020

Why are these changes needed?

There are several fields that are actually nullable from the gpustat library that the dashboard front-end had as non-nullable types. This led to the page crashing in scenarios where gpu utilization or memory utilization was not available.

Related issue number

Closes #11313

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Manually QA'd but not tested, like much of the front-end...

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 27, 2020
@mfitton mfitton added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Oct 29, 2020
@rkooo567 rkooo567 merged commit d6628cd into ray-project:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-ok The tagger certifies test failures are unrelated and assumes personal liability.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard] Some GPUs have gpu_utilization=null, breaking page

2 participants