Remove memory quota enforcement from actors#11480
Merged
ericl merged 4 commits intoray-project:masterfrom Oct 21, 2020
Merged
Conversation
edoakes
approved these changes
Oct 20, 2020
Collaborator
edoakes
left a comment
There was a problem hiding this comment.
Looks good, it's a bit strange to enforce resource limits for only one resource and not others (and best-effort at that).
Collaborator
|
@ericl looks like you need to update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Remove memory quota enforcement for actors, which prevents straightforward usage of the memory hint for scheduling without risk of killing workloads due to mis-estimation. This is backwards compatible since enforcement was always best-effort.
Related issue number
#11299
Checks
scripts/format.shto lint the changes in this PR.