Add random actor placement; fix cancellation callback; update test skips#11684
Merged
ericl merged 8 commits intoray-project:masterfrom Oct 31, 2020
Merged
Add random actor placement; fix cancellation callback; update test skips#11684ericl merged 8 commits intoray-project:masterfrom
ericl merged 8 commits intoray-project:masterfrom
Conversation
ericl
commented
Oct 29, 2020
| return task_resources; | ||
| }; | ||
|
|
||
| bool TaskRequest::IsEmpty() const { |
Contributor
Author
There was a problem hiding this comment.
This and other new code bits are copied from the previous random actor placement PR.
wuisawesome
reviewed
Oct 30, 2020
Contributor
Author
|
@wuisawesome updated |
wuisawesome
approved these changes
Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Port the new random actor placement PR; enable a few more test suites with fine-grained skips.
Also fix an issue where we didn't set the cancelled bit on task lease returns.
Fixes #9483