Merged
Conversation
* Update `jp` localized messages These translations were provided by Lionbridge. * `ja` localized messages patch via @nyatla * i18n/ja - remove extra code * Update app/_locales/ja/messages.json * Update messages.json Co-authored-by: kumavis <aaron@kumavis.me> Co-authored-by: kumavis <kumavis@users.noreply.github.com>
The `start:dev` script relies upon `electron` and `sqlite`, both of which had their install scripts disabled by `allow-scripts`. Without those two packages, `start:dev` crashes immediately. The manifest has been updated to ensure install scripts run for both packages. `start:dev` now works.
We now use string literals for all transaction category localized messages. This makes it easier to verify that we have translations for each of them, and that we aren't leaving any unused translations around.
* storybook - add signature request storybook entry * storybook + improve test data + lint * styles - apply flex and align center to --network
The `transferFrom` localized message has been unused at least since the transaction list redesign was implemented. The `transactionCategory` has been used directly as the localized message key since then. For most of the other categories this was fine, but for `transferFrom` the message differs slightly from the category (the category is `transferfrom`, with a lower-cased 'f').
The packages `eth-sig-util` and `ethashjs` have been updated to their latest in-range versions in the lockfile. This removes the last instance of `ethereumjs-abi@0.6.5` from our dependency tree, as well as the last non-optional instance of `sha3` (it's still present as a transitive dependency of an optional development dependency via `ganache`)
The `confirmTransaction` Redux slice had a lot of unused state and action creators. They have all been removed.
* Update zh_CN translation Co-authored-by: Mark Stacey <markjstacey@gmail.com>
The updates to `zh_CN` merged in #9388 were a fair bit behind the `develop` branch, so they ended up introducing various lint failures despite passing on CI on the PR. The localized messages have been updated to include English descriptions, and one extraneous message has been removed.
* origin/develop: Fix locale lint errors (#10410) Update zh_CN translation (#9388) cancel unapproved confirmations on network change (#10357) Remove unused `confirmTransaction` state (#10396) Update `eth-sig-util` and `ethashjs` lockfile versions (#10383) Fix `transferFrom` localized message (#10395) Storybook: Signature Request (#10400) Use string literals for transaction category localized messages (#10391) Fix `start:dev` script (#10399) storybook/i18n - add i18n party button (#10382) Update `ja` localized messages (#10265)
Sync `master` with `develop`
* use native currency in asset row * set native currency on startup
The `@include Paragraph` was added in one of the typography PRs but I believe it was intended for the token options text, not the icon. I believe the Paragraph only applies to text like everywhere else in the UI and this should be safe to remove from the icon to display the font-family from Font Awesome.
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com> Co-authored-by: Brad Decker <git@braddecker.dev>
* add MetaMaskTranslation component * add stories * Update ui/app/components/app/metamask-translation/metamask-translation.js Co-authored-by: Mark Stacey <markjstacey@gmail.com> * Update ui/app/components/app/metamask-translation/metamask-translation.js Co-authored-by: Mark Stacey <markjstacey@gmail.com> * fix regex Co-authored-by: Mark Stacey <markjstacey@gmail.com>
The CI script to ensure no LavaMoat policy changes are required has been failing despite there being no changes. It turns out that the command used to check for changes (`git diff-index`) was failing despite the lack of changes because the file was written again by `yarn lavamoat:auto` but git hadn't gotten around to updating its index since the write occurred, so it was considering it as changed until it verified it wasn't [1]. The command has been replaced by `git diff --exit-code --quiet`, which should do exactly the same thing except that it forces git to update its internal cache to verify whether changes are present. [1]: https://stackoverflow.com/questions/34807971/why-does-git-diff-index-head-result-change-for-touched-files-after-git-diff-or-g
4228890 to
93129d7
Compare
Collaborator
Author
Builds ready [93129d7]
Page Load Metrics (572 ± 38 ms)
|
* Add warning system for 'confusable' ENS names (#9129) Uses unicode.org's TR39 confusables.txt to display a warning when 'confusable' unicode points are detected. Currently only the `AddRecipient` component has been updated, but the new `Confusable` component could be used elsewhere The new `unicode-confusables` dependency adds close to 100KB to the bundle size, and around 30KB when gzipped. Adds 'tag' prop to the tooltop-v2 component Use $Red-500 for confusable ens warning Lint Tooltip component Update copy for confusing ENS domain warning. * Fix prop type Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Warnings were not shown on the Add Recipient page of the send flow. Now any send warnings will be shown. This can be tested using an ENS name with a confusable character in it (the confusable character warning will be shown). A condition was also removed that prevented any warnings or errors from rendering when the user had non-zero contacts or recent addresses. I have no idea why you'd want to hide warnings or errors if the user had no contacts or recent addresses. None of these errors even pertain to contacts or recent addresses.
93129d7 to
5026c1e
Compare
Collaborator
Author
Builds ready [5026c1e]
Page Load Metrics (686 ± 51 ms)
|
Collaborator
Author
Builds ready [1884ea2]
Page Load Metrics (560 ± 24 ms)
|
brad-decker
approved these changes
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 🚀