Skip to content

Update eth-sig-util and ethashjs lockfile versions#10383

Merged
Gudahtt merged 1 commit intodevelopfrom
update-eth-sig-util-and-ethashjs
Feb 8, 2021
Merged

Update eth-sig-util and ethashjs lockfile versions#10383
Gudahtt merged 1 commit intodevelopfrom
update-eth-sig-util-and-ethashjs

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Feb 5, 2021

The packages eth-sig-util and ethashjs have been updated to their latest in-range versions in the lockfile. This removes the last instance of ethereumjs-abi@0.6.5 from our dependency tree, as well as the last non-optional instance of sha3 (it's still present as a transitive dependency of an optional development dependency via ganache)

The packages `eth-sig-util` and `ethashjs` have been updated to their
latest in-range versions in the lockfile. This removes the last
instance of `ethereumjs-abi@0.6.5` from our dependency tree, as well as
the last non-optional instance of `sha3` (it's still present as a
transitive dependency of an optional development dependency via
`ganache`)
@Gudahtt Gudahtt requested a review from a team as a code owner February 5, 2021 14:37
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3157e67]
Page Load Metrics (886 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6011890168
domContentLoaded5459988859043
load5489998869043
domInteractive5449978849043

Copy link
Copy Markdown
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit 22f3e79 into develop Feb 8, 2021
@Gudahtt Gudahtt deleted the update-eth-sig-util-and-ethashjs branch February 8, 2021 21:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants