add chainId to all new transaction metadata#10528
Merged
brad-decker merged 1 commit intodevelopfrom Mar 1, 2021
Merged
Conversation
38ff85c to
9f308f9
Compare
9f308f9 to
5c13b5f
Compare
Collaborator
Builds ready [5c13b5f]
Page Load Metrics (560 ± 38 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
progresses #8668
adds
chainIdto all new transaction's metadata and prefers it when determining whether the transaction should be shown to the user. Falls back to themetamaskNetworkId. Further PRs will remove our reliance onmetamaskNetworkIdfor things like generating etherscan links, etc.