If any community contributors would like to help review this PR, it would be greatly appreciated!

I'll tag anyone here that has contributed in the past: @nyatla @mamiM

I wanted to give you all the opportunity to provide feedback because we owe our current translations to you. Please don't feel obliged if you don't have the time to review, and please let me know if you'd like me to stop tagging you for reviews in the future.

Thanks!

I'll review it now and make a fix list.

I started checking and fixing.
Progress is 116/687.
You can find it in this repository.
https://github.com/nyatla/metamask_PR10265/tree/master/message_translation_review20200126
Give me a little more time.

Thank you @nyatla - take as much time as you need!

memo.
Please let me know if anyone have any comments.

1. I feel that the description of connectToAllAccounts is incorrect.
   2.I'm trying to make "contacts" into an address book. (I will check the source later.)

2.I'm trying to make "contacts" into an address book.

Ah, great catch! That sounds good.

I feel that the description of connectToAllAccounts is incorrect.

Could you elaborate? Do you mean this description:

"will replace $1 in connectToAll, completing the sentence 'connect to all of your accounts', will be text that shows list of accounts on hover"

That is correct as far as I know 🤔. It's not a well written description though. I would update it to say:

"This will replace $1 in connectToAll, completing the sentence 'connect to all of your accounts'. This text will show a list of accounts on hover."

The hover behaviour is why that piece is translated separately; because we want to make a tooltip appear with additional information when the user hovers the mouse over that piece of text.

As an aside, I noticed that you wrote an interesting looking script to help with your efforts here. If there's any way we can make this process easier, I'd be interested in building a script like that into this repo directly.

We already have some scripts meant for working with these files. development/verify-locale-strings.js will validate and normalize these files, and development/missing-locale-strings.js will highlight any missing messages (it's newly merged so it's not on this branch, but it's on develop). But we don't have any script yet that puts the english translation alongside each message for comparison. That sounds potentially useful 🤔

I am sorry.
It is not description.

I thought it was a mistake because the current en message of "connectToAllAccounts" was "accounts".

backupApprovalInfo
backupApprovalNotice

Those are Secret Code / Secret, but this probably looks like a seed phrase.

1.rpcUrl is the New RPC URL. But it seems to the RPC URL.
2.endOfFlowMessage6
now: If you need to back up your seed phrase again, you can find it in Settings -> Security.
update: If you need to back up your seed phrase again, you can find it in Settings -> Security & Privacy.

I don't know how to fix and update Github, so I will verify everything in other repositories and then make a diff.

Currently , 601/687 translated.
I will finished it in a few days.

This PR has been rebased onto develop to ensure that the yourSigRequested message was not present (it was removed in #10300).

@nyatla Sure, a diff would be great! I can prepare the changes for GitHub myself.

The rebase I just did should hopefully not affect your work, since only one message was removed, and it was at the very end of the file.

This is pull request.
#10362

blocked: need CLA approval from nyatla in #10362

rebased for storybook CI 😁

some strange errors, should be unrelated

[2021-02-06 06:04:30.873][e2e]       AssertionError [ERR_ASSERTION]: '21.00025' == '0.00025'

Is this error bt my patch?
Would you give me a hint of the error?

@nyatla no the problem was not related to your changes

you can see part of the ja localization here
need to select ja from the localization dropdown at the top toolbar (globe icon)
https://242415-42009758-gh.circle-artifacts.com/0/storybook/index.html?path=/story/feecard--with-all-props

@kumavis OK, Thank you.

@kumavis

This looks like the header text.

There are two interpretations.

1. When the user requests Metamask to decrypt "something"
   復号をリクエスト

2. When the user requests Metamask to decrypt the any "request"
   リクエストを復号

I could not run how this component works, so I selected 2.