ja localized messages patch#10362
Closed
nyatla wants to merge 1 commit intoMetaMask:update-jp-localized-messagesfrom
Closed
ja localized messages patch#10362nyatla wants to merge 1 commit intoMetaMask:update-jp-localized-messagesfrom
ja localized messages patch#10362nyatla wants to merge 1 commit intoMetaMask:update-jp-localized-messagesfrom
Conversation
This is a patch based on pull request MetaMask#10265. I checked the meaning of automatic translation and updated. # Confirmation point * Translation accuracy * Appropriateness of expression at the display location using source code review.(It is not the display status) # Major changes * Delete spaces inserted by translation. * Adjusted the length of the translated text to be the same as or shorter than the original text. * unified the noun. (e.g. seed phrase, secret phrase) * Replacement of expressions not exist in Japanese (e.g. queue) * In addition, changing the word order, etc. * Expressions related to remittance. This is a Japanese-specific problem that considers all crypts and tokens as money. Depending on the location, it is divided into three expressions: "送る","送金",”送信”. "送金": When send ETH to any. ”送信”:When send Token ,Transaction, etc. "送る":When used to mean both transmission and remittance. I think missing-locale-strings.js will be 100% coverage.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Member
|
@nyatla thank you. please sign the Contributor License Agreement by writing a comment
thank you! |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
|
merging via #10265 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch based on pull request #10265.
I checked the meaning of automatic translation and updated.
Confirmation point
Major changes
This is a Japanese-specific problem that considers all crypts and tokens as money. Depending on the location, it is divided into three expressions: "送る","送金",”送信”.
"送金": When send ETH to any.
”送信”:When send Token ,Transaction, etc.
"送る":When used to mean both transmission and remittance.
I think missing-locale-strings.js will be 100% coverage.
Fixes: #
Explanation:
Manual testing steps: